[GitHub] [superset] kgabryje commented on a change in pull request #19078: [WIP] feat: add permalink to dashboard and explore

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #19078:
URL: https://github.com/apache/superset/pull/19078#discussion_r823787389



##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
##########
@@ -309,8 +310,8 @@ class SliceHeaderControls extends React.PureComponent<
 
         {supersetCanShare && (
           <ShareMenuItems
-            copyMenuItemTitle={t('Copy chart URL')}
-            emailMenuItemTitle={t('Share chart by email')}
+            copyMenuItemTitle={t('Copy permalink to clipboard')}

Review comment:
       I'm not sure if using a word "permalink" brings value to the end user. I feel like it might be confusing, and simply saying "link" or "URL" makes the intention clearer. I'd suggest asking a product manager for an opinion on that.

##########
File path: superset-frontend/src/dashboard/components/gridComponents/Tab.jsx
##########
@@ -86,6 +87,7 @@ const renderDraggableContentTop = dropProps =>
 
 export default class Tab extends React.PureComponent {
   constructor(props) {
+    console.log('$$', props);

Review comment:
       🙈 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org