You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dpogue (via GitHub)" <gi...@apache.org> on 2023/04/14 22:45:18 UTC
[GitHub] [cordova-ios] dpogue opened a new pull request, #1308: Remove long-unused codeSignResourceRules option
dpogue opened a new pull request, #1308:
URL: https://github.com/apache/cordova-ios/pull/1308
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Xcode hasn't supported specifying codesigning resource rules since pre-Mavericks, so this serves no purpose anymore.
Closes #563.
### Description
<!-- Describe your changes in detail -->
Remove support for the `--codeSignResourceRules` option.
### Testing
<!-- Please describe in detail how you tested your changes. -->
All unit tests pass.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter commented on pull request #1308: Remove long-unused codeSignResourceRules option
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1308:
URL: https://github.com/apache/cordova-ios/pull/1308#issuecomment-1509372618
## [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1308?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1308](https://codecov.io/gh/apache/cordova-ios/pull/1308?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f41fbb) into [master](https://codecov.io/gh/apache/cordova-ios/commit/3d6c71ab0f16c2772e827f1d258d5f028359d58a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d6c71a) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1308 +/- ##
==========================================
+ Coverage 78.48% 78.51% +0.03%
==========================================
Files 15 15
Lines 1780 1778 -2
==========================================
- Hits 1397 1396 -1
+ Misses 383 382 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/1308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2J1aWxkLmpz) | `67.21% <ø> (+0.18%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] erisu merged pull request #1308: chore: remove long-unused codeSignResourceRules option
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #1308:
URL: https://github.com/apache/cordova-ios/pull/1308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org