You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/03/23 10:03:08 UTC

[GitHub] [submarine] kobe860219 opened a new pull request #542: SUBMARINE-773. Support MLflow model registry

kobe860219 opened a new pull request #542:
URL: https://github.com/apache/submarine/pull/542


   ### What is this PR for?
   Update mlflow's docker image, it will provide a sqlite database for mlflow model registry. 
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-773
   
   ### How should this be tested?
   https://travis-ci.org/github/kobe860219/submarine/builds/764073079
   
   ### Screenshots (if appropriate)
   ![image](https://user-images.githubusercontent.com/48027290/112129040-f482c980-8c01-11eb-9ff8-9fe2098c56ae.png)
   
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu commented on pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #542:
URL: https://github.com/apache/submarine/pull/542#issuecomment-829236983


   Except for the port of tracking server should be modified to 5000.
   Other parts are perfect! Thanks for your contribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu commented on a change in pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on a change in pull request #542:
URL: https://github.com/apache/submarine/pull/542#discussion_r623671216



##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -109,10 +109,17 @@ RUN cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipyn
 # Install latest stable qlib
 RUN pip install numpy==1.19.5 pyqlib==0.6.1
 
+# Install mlflow & minio dependencies
+RUN pip install boto3

Review comment:
       the version should be fixed too




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kobe860219 commented on pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #542:
URL: https://github.com/apache/submarine/pull/542#issuecomment-809184490


   Some problem need to fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kobe860219 commented on pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #542:
URL: https://github.com/apache/submarine/pull/542#issuecomment-818495667


   @xunliu Still working !! I'm going to try mlflow server with nfs and mysql.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kobe860219 merged pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
kobe860219 merged pull request #542:
URL: https://github.com/apache/submarine/pull/542


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu commented on pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #542:
URL: https://github.com/apache/submarine/pull/542#issuecomment-828908398


   There is some problem with my local testing. Still trying to find the cause.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu commented on pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #542:
URL: https://github.com/apache/submarine/pull/542#issuecomment-830198378


   +1 LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu commented on a change in pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on a change in pull request #542:
URL: https://github.com/apache/submarine/pull/542#discussion_r623670883



##########
File path: dev-support/docker-images/mlflow/Dockerfile
##########
@@ -17,12 +17,24 @@ FROM python:3.7.0-slim
 
 RUN pip install mlflow
 
-RUN mkdir /submarine-mlflow
+RUN apt-get update && apt-get -y install --no-install-recommends default-libmysqlclient-dev libpq-dev build-essential sqlite3 wget
+    
+RUN pip install \
+    mlflow \
+    sqlalchemy \
+    boto3

Review comment:
       One more advice: these packages' version should be fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu commented on a change in pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on a change in pull request #542:
URL: https://github.com/apache/submarine/pull/542#discussion_r622929123



##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -107,12 +107,16 @@ RUN cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipyn
     rm submarine -rf
 
 # Install latest stable qlib
-RUN pip install numpy==1.19.5 pyqlib==0.6.1
+RUN pip install numpy==1.19.5 pyqlib==0.6.1 boto3

Review comment:
       boto3 should be separated to another line with the comment "Install minio dependencies"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] xunliu commented on pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
xunliu commented on pull request #542:
URL: https://github.com/apache/submarine/pull/542#issuecomment-818386126


   @kobe860219 What is the status for this PR, it complated?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu removed a comment on pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
ByronHsu removed a comment on pull request #542:
URL: https://github.com/apache/submarine/pull/542#issuecomment-829895543


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kobe860219 commented on pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #542:
URL: https://github.com/apache/submarine/pull/542#issuecomment-828122950


   Use mlflow in subnarine jupyter notebook
   <img width="1196" alt="截圖 2021-04-28 上午11 46 40" src="https://user-images.githubusercontent.com/48027290/116343947-0581b480-a818-11eb-9873-9f68955c5143.png">
   
   MLflow UI experiment
   <img width="1197" alt="截圖 2021-04-28 上午11 47 18" src="https://user-images.githubusercontent.com/48027290/116344027-264a0a00-a818-11eb-907b-0ea61e279b28.png">
   <img width="1212" alt="截圖 2021-04-28 上午11 47 05" src="https://user-images.githubusercontent.com/48027290/116344052-2c3feb00-a818-11eb-856d-000038fe8bed.png">
   
   MLflow Model Registry
   <img width="1215" alt="截圖 2021-04-28 上午11 47 30" src="https://user-images.githubusercontent.com/48027290/116344077-3661e980-a818-11eb-9905-86127c4f1b94.png">
   
   Artifacts in minIO
   <img width="1235" alt="截圖 2021-04-28 上午11 47 44" src="https://user-images.githubusercontent.com/48027290/116344119-4679c900-a818-11eb-810f-db848337c6a0.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu commented on pull request #542: SUBMARINE-773. Support MLflow model registry

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #542:
URL: https://github.com/apache/submarine/pull/542#issuecomment-829895543


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org