You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Christof Lorenz (Jira)" <ji...@apache.org> on 2020/03/12 09:04:00 UTC
[jira] [Comment Edited] (SOLR-13264) unexpected autoscaling
set-trigger response
[ https://issues.apache.org/jira/browse/SOLR-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057728#comment-17057728 ]
Christof Lorenz edited comment on SOLR-13264 at 3/12/20, 9:03 AM:
------------------------------------------------------------------
This is where the problem is, it looks like the belowOp and aboveOp are not being added to the validProperties:
{code:java}
public IndexSizeTrigger(String name) {
super(TriggerEventType.INDEXSIZE, name);
TriggerUtils.validProperties(validProperties,
ABOVE_BYTES_PROP, ABOVE_DOCS_PROP, BELOW_BYTES_PROP, BELOW_DOCS_PROP, COLLECTIONS_PROP);
}{code}
Without being able to define the Op the trigger is not usable at all.
I am currently working with 7.4 looking to update to 8.x
was (Author: lochri):
This is where the problem is, it looks like the belowOp and aboveOp are not being added to the validProperties:
{code:java}
public IndexSizeTrigger(String name) {
super(TriggerEventType.INDEXSIZE, name);
TriggerUtils.validProperties(validProperties,
ABOVE_BYTES_PROP, ABOVE_DOCS_PROP, BELOW_BYTES_PROP, BELOW_DOCS_PROP, COLLECTIONS_PROP);
}{code}
Without being able to define the Op the trigger is not usable at all.
> unexpected autoscaling set-trigger response
> -------------------------------------------
>
> Key: SOLR-13264
> URL: https://issues.apache.org/jira/browse/SOLR-13264
> Project: Solr
> Issue Type: Bug
> Components: AutoScaling
> Reporter: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-13264.patch, SOLR-13264.patch
>
>
> Steps to reproduce:
> {code}
> ./bin/solr start -cloud -noprompt
> ./bin/solr create -c demo -d _default -shards 1 -replicationFactor 1
> curl "http://localhost:8983/solr/admin/autoscaling" -d'
> {
> "set-trigger" : {
> "name" : "index_size_trigger",
> "event" : "indexSize",
> "aboveDocs" : 12345,
> "aboveOp" : "SPLITSHARD",
> "enabled" : true,
> "actions" : [
> {
> "name" : "compute_plan",
> "class": "solr.ComputePlanAction"
> }
> ]
> }
> }
> '
> ./bin/solr stop -all
> {code}
> The {{aboveOp}} is documented on https://lucene.apache.org/solr/guide/7_6/solrcloud-autoscaling-triggers.html#index-size-trigger and logically should be accepted (even though it is actually the default) but unexpectedly an error message is returned {{"Error validating trigger config index_size_trigger: TriggerValidationException\{name=index_size_trigger, details='\{aboveOp=unknown property\}'\}"}}.
> From a quick look it seems that in the {{IndexSizeTrigger}} constructor additional values need to be passed to the {{TriggerUtils.validProperties}} method i.e. aboveOp, belowOp and maybe others too i.e. aboveSize/belowSize/etc. Illustrative patch to follow. Thank you.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org