You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/05/23 08:08:08 UTC
Review Request: Marvin logger output showing repeated log lines.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11340/
-----------------------------------------------------------
Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
Description
-------
In unit tests runs the same log output line is repeated for number tests in a class, making log unreadable.
This is because we are creating a logger by class name for each test load in loadTestsFromFile()
with this fix not logger will log the test case and class name.
Diffs
-----
tools/marvin/marvin/TestCaseExecuteEngine.py 5743868
Diff: https://reviews.apache.org/r/11340/diff/
Testing
-------
Testing Done.
Thanks,
Ashutosh Kelkar
Re: Review Request: Marvin logger output showing repeated log lines.
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11340/
-----------------------------------------------------------
(Updated May 28, 2013, 5:40 a.m.)
Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
Description
-------
In unit tests runs the same log output line is repeated for number tests in a class, making log unreadable.
This is because we are creating a logger by class name for each test load in loadTestsFromFile()
with this fix now logger will log the test case and class name.
This addresses bug CLOUDSTACK-2703.
Diffs
-----
tools/marvin/marvin/TestCaseExecuteEngine.py 5743868
Diff: https://reviews.apache.org/r/11340/diff/
Testing
-------
Testing Done.
Thanks,
Ashutosh Kelkar
Re: Review Request: Marvin logger output showing repeated log lines.
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On May 23, 2013, 6:15 a.m., Prasanna Santhanam wrote:
> > Can you create a bug report for this? Otherwise the patch LGTM.
Created a bug report CLOUDSTACK-2703
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11340/#review20930
-----------------------------------------------------------
On May 23, 2013, 6:09 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11340/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 6:09 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
>
>
> Description
> -------
>
> In unit tests runs the same log output line is repeated for number tests in a class, making log unreadable.
> This is because we are creating a logger by class name for each test load in loadTestsFromFile()
>
> with this fix now logger will log the test case and class name.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/TestCaseExecuteEngine.py 5743868
>
> Diff: https://reviews.apache.org/r/11340/diff/
>
>
> Testing
> -------
>
> Testing Done.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request: Marvin logger output showing repeated log lines.
Posted by Prasanna Santhanam <ts...@apache.org>.
> On May 23, 2013, 6:15 a.m., Prasanna Santhanam wrote:
> > Can you create a bug report for this? Otherwise the patch LGTM.
>
> Ashutosh Kelkar wrote:
> Created a bug report CLOUDSTACK-2703
Thanks, this will correct the TestCase logger when running tests using python -m marvin.deployAndRun. The nose test runner however doesn't duplicate the log messages.
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11340/#review20930
-----------------------------------------------------------
On May 28, 2013, 5:40 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11340/
> -----------------------------------------------------------
>
> (Updated May 28, 2013, 5:40 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
>
>
> Description
> -------
>
> In unit tests runs the same log output line is repeated for number tests in a class, making log unreadable.
> This is because we are creating a logger by class name for each test load in loadTestsFromFile()
>
> with this fix now logger will log the test case and class name.
>
>
> This addresses bug CLOUDSTACK-2703.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/TestCaseExecuteEngine.py 5743868
>
> Diff: https://reviews.apache.org/r/11340/diff/
>
>
> Testing
> -------
>
> Testing Done.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request: Marvin logger output showing repeated log lines.
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11340/#review20930
-----------------------------------------------------------
Can you create a bug report for this? Otherwise the patch LGTM.
- Prasanna Santhanam
On May 23, 2013, 6:09 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11340/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 6:09 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
>
>
> Description
> -------
>
> In unit tests runs the same log output line is repeated for number tests in a class, making log unreadable.
> This is because we are creating a logger by class name for each test load in loadTestsFromFile()
>
> with this fix now logger will log the test case and class name.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/TestCaseExecuteEngine.py 5743868
>
> Diff: https://reviews.apache.org/r/11340/diff/
>
>
> Testing
> -------
>
> Testing Done.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request: Marvin logger output showing repeated log lines.
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11340/
-----------------------------------------------------------
(Updated May 23, 2013, 6:09 a.m.)
Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
Description (updated)
-------
In unit tests runs the same log output line is repeated for number tests in a class, making log unreadable.
This is because we are creating a logger by class name for each test load in loadTestsFromFile()
with this fix now logger will log the test case and class name.
Diffs
-----
tools/marvin/marvin/TestCaseExecuteEngine.py 5743868
Diff: https://reviews.apache.org/r/11340/diff/
Testing
-------
Testing Done.
Thanks,
Ashutosh Kelkar