You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/02/11 03:42:30 UTC
[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request #8014: [Enhancement] Open clang compile warning option and resolve compile error Part1
BiteTheDDDDt opened a new pull request #8014:
URL: https://github.com/apache/incubator-doris/pull/8014
# Proposed changes
Issue Number: #8013
This pr remove those compile options:
```cmake
-Wno-address-of-packed-member
-Wno-ambiguous-reversed-operator
-Wno-atomic-implicit-seq-cst
-Wno-unused-but-set-variable
-Wno-unused-const-variable
-Wno-unused-exception-parameter
-Wno-unused-function
-Wno-unused-local-typedef
-Wno-unused-value
-Wno-unused-variable
-Wno-variadic-macros
-Wno-zero-as-null-pointer-constant
```
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #8014: [Enhancement] Open clang compile warning option and resolve compile error Part1
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #8014:
URL: https://github.com/apache/incubator-doris/pull/8014#discussion_r805170514
##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -258,8 +256,7 @@ static Status insert_int_value(const rapidjson::Value& col, PrimitiveType type,
return Status::OK();
}
-ScrollParser::ScrollParser(bool doc_value_mode)
- : _scroll_id(""), _size(0), _line_index(0), _doc_value_mode(doc_value_mode) {}
+ScrollParser::ScrollParser(bool doc_value_mode) : _scroll_id(""), _size(0), _line_index(0) {}
Review comment:
`doc_value_mode` is not used?
##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -258,8 +256,7 @@ static Status insert_int_value(const rapidjson::Value& col, PrimitiveType type,
return Status::OK();
}
-ScrollParser::ScrollParser(bool doc_value_mode)
- : _scroll_id(""), _size(0), _line_index(0), _doc_value_mode(doc_value_mode) {}
+ScrollParser::ScrollParser(bool doc_value_mode) : _scroll_id(""), _size(0), _line_index(0) {}
Review comment:
So why not remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8014: [Enhancement] Open clang compile warning option and resolve compile error Part1
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8014:
URL: https://github.com/apache/incubator-doris/pull/8014#discussion_r805176570
##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -258,8 +256,7 @@ static Status insert_int_value(const rapidjson::Value& col, PrimitiveType type,
return Status::OK();
}
-ScrollParser::ScrollParser(bool doc_value_mode)
- : _scroll_id(""), _size(0), _line_index(0), _doc_value_mode(doc_value_mode) {}
+ScrollParser::ScrollParser(bool doc_value_mode) : _scroll_id(""), _size(0), _line_index(0) {}
Review comment:
> `doc_value_mode` is not used?
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8014: [Enhancement] Open clang compile warning option and resolve compile error Part1
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8014:
URL: https://github.com/apache/incubator-doris/pull/8014#discussion_r805176570
##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -258,8 +256,7 @@ static Status insert_int_value(const rapidjson::Value& col, PrimitiveType type,
return Status::OK();
}
-ScrollParser::ScrollParser(bool doc_value_mode)
- : _scroll_id(""), _size(0), _line_index(0), _doc_value_mode(doc_value_mode) {}
+ScrollParser::ScrollParser(bool doc_value_mode) : _scroll_id(""), _size(0), _line_index(0) {}
Review comment:
> `doc_value_mode` is not used?
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #8014: [Enhancement] Open clang compile warning option and resolve compile error Part1
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #8014:
URL: https://github.com/apache/incubator-doris/pull/8014#discussion_r805306938
##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -258,8 +256,7 @@ static Status insert_int_value(const rapidjson::Value& col, PrimitiveType type,
return Status::OK();
}
-ScrollParser::ScrollParser(bool doc_value_mode)
- : _scroll_id(""), _size(0), _line_index(0), _doc_value_mode(doc_value_mode) {}
+ScrollParser::ScrollParser(bool doc_value_mode) : _scroll_id(""), _size(0), _line_index(0) {}
Review comment:
So why not remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #8014: [Enhancement] Open clang compile warning option and resolve compile error Part1
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #8014:
URL: https://github.com/apache/incubator-doris/pull/8014#discussion_r805170514
##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -258,8 +256,7 @@ static Status insert_int_value(const rapidjson::Value& col, PrimitiveType type,
return Status::OK();
}
-ScrollParser::ScrollParser(bool doc_value_mode)
- : _scroll_id(""), _size(0), _line_index(0), _doc_value_mode(doc_value_mode) {}
+ScrollParser::ScrollParser(bool doc_value_mode) : _scroll_id(""), _size(0), _line_index(0) {}
Review comment:
`doc_value_mode` is not used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #8014: [Enhancement] Open clang compile warning option and resolve compile error Part1
Posted by GitBox <gi...@apache.org>.
yangzhg commented on pull request #8014:
URL: https://github.com/apache/incubator-doris/pull/8014#issuecomment-1042514814
I had a pr #8069 have fix all warnings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt closed pull request #8014: [Enhancement] Open clang compile warning option and resolve compile error Part1
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt closed pull request #8014:
URL: https://github.com/apache/incubator-doris/pull/8014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8014: [Enhancement] Open clang compile warning option and resolve compile error Part1
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8014:
URL: https://github.com/apache/incubator-doris/pull/8014#discussion_r805551873
##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -258,8 +256,7 @@ static Status insert_int_value(const rapidjson::Value& col, PrimitiveType type,
return Status::OK();
}
-ScrollParser::ScrollParser(bool doc_value_mode)
- : _scroll_id(""), _size(0), _line_index(0), _doc_value_mode(doc_value_mode) {}
+ScrollParser::ScrollParser(bool doc_value_mode) : _scroll_id(""), _size(0), _line_index(0) {}
Review comment:
> So why not remove it?
Now I have remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org