[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #16131: Fix for duplicate subgraph inputs/outputs

[GitBox <gi...@apache.org>]

samskalicky commented on a change in pull request #16131:
URL: https://github.com/apache/incubator-mxnet/pull/16131#discussion_r483755049



##########
File path: src/operator/subgraph/build_subgraph.cc
##########
@@ -537,10 +537,11 @@ void FindOutputEntries(nnvm::Graph* g,
  */
 void CutGraphInputs(const std::vector<nnvm::NodeEntry*> &input_entries,
                     std::vector<nnvm::NodeEntry> *orig_entries,
+                    std::vector<nnvm::NodeEntry> *unique_inputs,

Review comment:
       Thanks for the suggestion @hahtk, but we cant modify `orig_entries` since we need it unmodified for ReattachGraphInputs:
   https://github.com/apache/incubator-mxnet/blob/e249d71ad4621afcba7f0f3af77095a3f9a4bc83/src/operator/subgraph/build_subgraph.cc#L578
   this is used to reject a subgraph from the reviewSubgraph API:
   https://github.com/apache/incubator-mxnet/blob/e249d71ad4621afcba7f0f3af77095a3f9a4bc83/src/operator/subgraph/build_subgraph.cc#L657
   the example you provided doesnt work in the latest version of MXNet where you can reject a subgraph by returning nullptr from CreateSubgraphNode here: https://github.com/apache/incubator-mxnet/blob/e249d71ad4621afcba7f0f3af77095a3f9a4bc83/src/operator/subgraph/build_subgraph.cc#L630-L633




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org