You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/10/25 06:59:19 UTC
[PR] [VARIANT 7/8] VARIANT response encoding and Java/JDBC clients [pinot]
xiangfu0 opened a new pull request, #20033:
URL: https://github.com/apache/pinot/pull/20033
## What
Renders VARIANT results as JSON in the response encoders and in the Java and JDBC clients.
## Changes
- `JsonResponseEncoder` and `ArrowResponseEncoder` treat VARIANT as text: the broker renders it with `variantToJson`.
- Java client `ResultSet`/`ResultTableResultSet`/`GrpcResultSet`, and JDBC `PinotResultSet`/`PinotGrpcResultSet`/`DriverUtils`, map VARIANT to a JSON string.
## Depends on
6/8 (stacking order only; the code itself needs 2/8).
## About this PR
This is **part 7 of 8** splitting #19101 (end-to-end Parquet VARIANT support) into layered PRs. #19101 stays open as the umbrella with the full feature description; [`docs/design/VARIANT.md`](https://github.com/apache/pinot/blob/xiangfu0/variant-split/01-spi-foundation/docs/design/VARIANT.md) (added in 1/8) is the design reference.
The base branch is the previous PR in the stack, so the diff below is exactly this layer. Each layer compiles and passes its own tests on top of the one below it, and the top of the stack has the same tree as #19101.
> VARIANT is not usable end to end until the whole stack has landed. Raw-value opacity guards arrive in 5/8 (single-stage) and 6/8 (multi-stage), so please don't create VARIANT columns on a build that has only part of the stack. The stack should land within one release.
### Full stack (merge bottom → top)
_filled in once all PRs are open_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [VARIANT 7/8] VARIANT response encoding and Java/JDBC clients [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20033:
URL: https://github.com/apache/pinot/pull/20033#issuecomment-6461737817
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/20033?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `95.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.55%. Comparing base ([`3891953`](https://app.codecov.io/gh/apache/pinot/commit/3891953d4ca4f4d91f2498c8cbcf602b85385350?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c619e09`](https://app.codecov.io/gh/apache/pinot/commit/c619e09b57548fd69aa87c4a77c0cc71a0243fcb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/20033?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...g/apache/pinot/client/grpc/PinotGrpcResultSet.java](https://app.codecov.io/gh/apache/pinot/pull/20033?src=pr&el=tree&filepath=pinot-clients%2Fpinot-jdbc-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fclient%2Fgrpc%2FPinotGrpcResultSet.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY2xpZW50cy9waW5vdC1qZGJjLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L2dycGMvUGlub3RHcnBjUmVzdWx0U2V0LmphdmE=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (3891953) and HEAD (c619e09). Click for more details.
>
> <details><summary>HEAD has 11 uploads less than BASE</summary>
>
>| Flag | BASE (3891953) | HEAD (c619e09) |
>|------|------|------|
>|lane-a|1|0|
>|integration|2|0|
>|java-25|3|1|
>|integration1|2|0|
>|temurin|3|1|
>|lane-b|1|0|
>|unittests1|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## xiangfu0/variant-split/06-mse-query #20033 +/- ##
==========================================================================
- Coverage 59.35% 41.55% -17.80%
- Complexity 7 1614 +1607
==========================================================================
Files 2758 3573 +815
Lines 175401 238449 +63048
Branches 29035 38376 +9341
==========================================================================
- Hits 104105 99098 -5007
- Misses 62441 130452 +68011
- Partials 8855 8899 +44
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/20033/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/20033/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/20033/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-25](https://app.codecov.io/gh/apache/pinot/pull/20033/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.55% <95.00%> (-17.80%)` | :arrow_down: |
| [lane-a](https://app.codecov.io/gh/apache/pinot/pull/20033/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [lane-b](https://app.codecov.io/gh/apache/pinot/pull/20033/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/20033/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.55% <95.00%> (-17.80%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/20033/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.55% <95.00%> (-17.80%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/20033/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/20033/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.55% <95.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/20033?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org