[GitHub] spark pull request #18734: [SPARK-21070][PYSPARK] Attempt to update cloudpic...

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18734#discussion_r130763298
  
    --- Diff: python/pyspark/cloudpickle.py ---
    @@ -220,12 +322,7 @@ def save_function(self, obj, name=None):
     
             if name is None:
                 name = obj.__name__
    -        try:
    -            # whichmodule() could fail, see
    -            # https://bitbucket.org/gutworth/six/issues/63/importing-six-breaks-pickling
    -            modname = pickle.whichmodule(obj, name)
    -        except Exception:
    -            modname = None
    +        modname = pickle.whichmodule(obj, name)
    --- End diff --
    
    @holdenk, would it be safe to remove? It looks a custom fix we did to deal with https://issues.apache.org/jira/browse/SPARK-16077 and sounds we should keep this as https://bitbucket.org/gutworth/six/issues/63/importing-six-breaks-pickling describes Python 2.7.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org