You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/17 20:51:40 UTC

[GitHub] phoenix24 commented on a change in pull request #4332: [AIRFLOW-3522] Add support for sending Slack attachments

phoenix24 commented on a change in pull request #4332: [AIRFLOW-3522] Add support for sending Slack attachments
URL: https://github.com/apache/incubator-airflow/pull/4332#discussion_r242311568
 
 

 ##########
 File path: airflow/contrib/operators/slack_webhook_operator.py
 ##########
 @@ -37,6 +37,8 @@ class SlackWebhookOperator(SimpleHttpOperator):
     :type webhook_token: str
     :param message: The message you want to send on Slack
     :type message: str
+    :param attachments: The attachments you want to send on Slack
+    :type attachments: list
 
 Review comment:
   in the similar spirit as above code-review, this doc string could also be a made a little verbose.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services