[jira] [Commented] (SOLR-9947) Miscellaneous metrics cleanup

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814835#comment-15814835 ] 

Shalin Shekhar Mangar commented on SOLR-9947:
---------------------------------------------

A few of the things to fix:
# Config handler is under "OTHERS" category
# The /update/* handlers are under "QUERYHANDLER"
# The container level metrics such as "core.*" gauges, threadPool.coreContainerWorkExecutor and threadPool.coreLoadExecutor are without a category unlike other metrics. Perhaps we can introduce a CONTAINER category?
# InfoHandler which is created in CoreContainer and has sub-handler such as /admin/logging, /admin/threads etc which show up in each core. I am not sure why.

I think we are too tied with SolrInfoMBean and the categories that exist already. It feels wrong for a new API to use outdated category names. For example, "/replication" is not a query handler, it is something else entirely. Same for core admin handlers and other such stuff. I am not sure how to fix this without breaking back-compat with existing monitoring solutions. What do you think [~ab]?

> Miscellaneous metrics cleanup
> -----------------------------
>
>                 Key: SOLR-9947
>                 URL: https://issues.apache.org/jira/browse/SOLR-9947
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: master (7.0), 6.4
>
>
> Misc cleanup in metrics API to fix:
> # metrics reporting themselves under the wrong category
> # core container metrics are without a category



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org