You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "vladimirg-db (via GitHub)" <gi...@apache.org> on 2024/11/01 15:14:52 UTC

[PR] [SPARK-50204][SQL] Factor out `HiveTableRelation` read path resolution [spark]

vladimirg-db opened a new pull request, #48738:
URL: https://github.com/apache/spark/pull/48738

   ### What changes were proposed in this pull request?
   
   Factor out `HiveTableRelation` resolution into a separate `RelationConversions` method to reuse it in the single-pass Analyzer.
   
   ### Why are the changes needed?
   
   Context: https://issues.apache.org/jira/browse/SPARK-49834
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing tests.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   copilot.vim.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-50204][SQL] Factor out `HiveTableRelation` read path resolution [spark]

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #48738: [SPARK-50204][SQL] Factor out `HiveTableRelation` read path resolution
URL: https://github.com/apache/spark/pull/48738


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-50204][SQL] Factor out `HiveTableRelation` read path resolution [spark]

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #48738:
URL: https://github.com/apache/spark/pull/48738#issuecomment-2452341121

   +1, LGTM. Merging to master.
   Thank you, @vladimirg-db.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org