[GitHub] [superset] justinpark commented on a diff in pull request #23547: feat: Shows user charts by default when editing a dashboard

["justinpark (via GitHub)" <gi...@apache.org>]

justinpark commented on code in PR #23547:
URL: https://github.com/apache/superset/pull/23547#discussion_r1157506357


##########
superset-frontend/src/dashboard/components/SliceAdder.jsx:
##########
@@ -68,15 +76,20 @@ const KEYS_TO_SORT = {
   changed_on: t('recent'),
 };
 
-const DEFAULT_SORT_KEY = 'changed_on';
+export const DEFAULT_SORT_KEY = 'changed_on';
 
 const DEFAULT_CELL_HEIGHT = 128;
 
 const Controls = styled.div`
-  display: flex;
-  flex-direction: row;
-  padding: ${({ theme }) => theme.gridUnit * 3}px;
-  padding-top: ${({ theme }) => theme.gridUnit * 4}px;
+  ${({ theme }) => `
+    display: flex;
+    flex-direction: row;
+    padding:
+      ${theme.gridUnit * 4}px
+      ${theme.gridUnit * 3}px
+      ${theme.gridUnit * 4}px

Review Comment:
   nit: it(bottom) was 3px in the previous style.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org