You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by andrei-ivanov <gi...@git.apache.org> on 2018/09/23 11:26:28 UTC

[GitHub] logging-log4j-audit pull request #9: [LOG4J2-2452]

GitHub user andrei-ivanov opened a pull request:

    https://github.com/apache/logging-log4j-audit/pull/9

    [LOG4J2-2452]

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andrei-ivanov/logging-log4j-audit LOG4J2-2452

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j-audit/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
    
----
commit 478dfb784fb14b2ba6aa013d56c075fe053f6315
Author: Andrei Ivanov <an...@...>
Date:   2018-09-23T11:25:41Z

    [LOG4J2-2452]

----


---

[GitHub] logging-log4j-audit issue #9: [LOG4J2-2452]

Posted by andrei-ivanov <gi...@git.apache.org>.

Github user andrei-ivanov commented on the issue:

    https://github.com/apache/logging-log4j-audit/pull/9
  
    I couldn't pass and use the Maven plugin logger to the `InterfacesGenerator` and `ClassGenerator` as they are not located in `log4j-audit-maven-plugin`, but in `log4j-audit-api` and I'm not sure if it's appropriate, as they seem to also be defined as Spring components.
    
    I guess some sort of adapter should be used, but that complicates things 😟


---

[GitHub] logging-log4j-audit pull request #9: [LOG4J2-2452]

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/logging-log4j-audit/pull/9


---