You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "zjhmale (GitHub)" <gi...@apache.org> on 2020/02/24 00:17:26 UTC
[GitHub] [dubbo-go] zjhmale opened pull request #372: Fix/ignore
apollo prop file
```
Untracked files:
(use "git add <file>..." to include in what will be committed)
config_center/apollo/mockDubbog.properties.json
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/372 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zjhmale commented on issue #372: Fix/ignore
apollo prop file
Posted by "zjhmale (GitHub)" <gi...@apache.org>.
ok, thanks for the hint, will checkout `develop` then
[ Full content available at: https://github.com/apache/dubbo-go/pull/372 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zjhmale closed pull request #372: Fix/ignore
apollo prop file
Posted by "zjhmale (GitHub)" <gi...@apache.org>.
[ pull request closed by zjhmale ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/372 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on issue #372: Fix/ignore apollo
prop file
Posted by "zouyx (GitHub)" <gi...@apache.org>.
@zjhmale thanks for your PR. In develop branch, UT will delete this file once it finish. you can try it.
https://github.com/apache/dubbo-go/blob/67ccfb23bfa27ac1ee178a2a704467b15316ac47/config_center/apollo/impl_test.go#L269
[ Full content available at: https://github.com/apache/dubbo-go/pull/372 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #372: Fix/ignore
apollo prop file
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/372?src=pr&el=h1) Report
> Merging [#372](https://codecov.io/gh/apache/dubbo-go/pull/372?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/33f82cd154a3ee5ef861c6465333c4945c9d4b1a?src=pr&el=desc) will **decrease** coverage by `0.46%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/372?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
- Coverage 67.16% 66.69% -0.47%
==========================================
Files 145 145
Lines 7692 7692
==========================================
- Hits 5166 5130 -36
- Misses 2036 2072 +36
Partials 490 490
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/372?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/372/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `56.75% <0%> (-6.49%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/372/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `74.77% <0%> (-6.43%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/372/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `63.75% <0%> (-5%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/372/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/372?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/372?src=pr&el=footer). Last update [33f82cd...41c3e8e](https://codecov.io/gh/apache/dubbo-go/pull/372?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/372 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org