You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/08/30 20:13:26 UTC

[GitHub] sohami commented on a change in pull request #1453: DRILL-6710: Disallow negative scale for decimal data type

sohami commented on a change in pull request #1453: DRILL-6710: Disallow negative scale for decimal data type
URL: https://github.com/apache/drill/pull/1453#discussion_r214163791
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/output/DecimalReturnTypeInference.java
 ##########
 @@ -277,7 +277,7 @@
 
       return TypeProtos.MajorType.newBuilder()
           .setMinorType(attributes.getReturnValue().getType().getMinorType())
-          .setScale(scale)
+          .setScale(Math.max(scale, 0))
 
 Review comment:
   How about adjusting precision/scale for other `ReturnTypeInference` like `DecimalAggReturnTypeInference, DecimalMaxScaleReturnTypeInference, etc`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services