[GitHub] dspavlov commented on a change in pull request #5856: IGNITE-10974 Release page lock even if exception throws on beforeReleaseWrite

[GitBox <gi...@apache.org>]

dspavlov commented on a change in pull request #5856: IGNITE-10974 Release page lock even if exception throws on beforeReleaseWrite
URL: https://github.com/apache/ignite/pull/5856#discussion_r249040221
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
 ##########
 @@ -1543,24 +1543,32 @@ private void writeUnlockPage(
         if (markDirty)
             setDirty(fullId, page, markDirty, false);
 
-        beforeReleaseWrite(fullId, page + PAGE_OVERHEAD, pageWalRec);
-
-        long pageId = PageIO.getPageId(page + PAGE_OVERHEAD);
+        try {
+            beforeReleaseWrite(fullId, page + PAGE_OVERHEAD, pageWalRec);
+        }
+        catch (IgniteCheckedException e) {
 
 Review comment:
   I'm not sure if IgniteCheckedException can be thrown here because it is caught in the method. Can it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services