[GitHub] [maven-integration-testing] gnodet commented on a diff in pull request #184: Modernize IT plugins to use annotations

[GitBox <gi...@apache.org>]

gnodet commented on code in PR #184:
URL: https://github.com/apache/maven-integration-testing/pull/184#discussion_r989466447


##########
core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java:
##########
@@ -35,42 +38,35 @@
 /**
  * Checks the general retrieval of components from active component collections.
  *
- * @goal check
- * @phase validate
- *
  * @author Benjamin Bentmann
  */
+@Mojo( name = "check", defaultPhase = LifecyclePhase.VALIDATE )
 public class CheckMojo
     extends AbstractMojo
 {
 
     /**
      * Project base directory used for manual path alignment.
-     *
-     * @parameter default-value="${basedir}"
-     * @readonly
      */
+    @Parameter( defaultValue = "${basedir}", readonly = true )
     private File basedir;
 
     /**
      * The available components, as a map.
-     *
-     * @component role="org.apache.maven.plugin.coreit.Component"
      */
-    private Map componentMap;
+    @org.apache.maven.plugins.annotations.Component

Review Comment:
   This is not doable.  The full declaration looks like:
   ```
       @org.apache.maven.plugins.annotations.Component
       private Map<String, Component> componentMap;
   ```
   The `Component` interface is defined by at least 4 modules...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org