[jira] [Commented] (GEODE-3023) TcpServer thread can be blocked in processRequest

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038341#comment-16038341 ] 

ASF GitHub Bot commented on GEODE-3023:
---------------------------------------

GitHub user vahrama opened a pull request:

    https://github.com/apache/geode/pull/564

    GEODE-3023 TcpServer thread can be blocked in processRequest

    Move socket timeout setting before configureServerSSLSocket to ensure
    that SSL handshake will return in the allotted time and will not wait
    forever if other side is unresponsive.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    Yes, https://issues.apache.org/jira/browse/GEODE-3023
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    No
    - [ ] Is your initial contribution a single, squashed commit?
    Yes
    - [ ] Does `gradlew build` run cleanly?
    Actually build is sucessfull, but there are 12 test failures. But this is not related to the fix done with this commit. Same is reported even on clean tree.
    Here are failing tests:
    HelpBlockUnitTest. testToString
    HelperUnitTest. testGetLongHelp
    HelperUnitTest. testGetShortHelp
    HelperUnitTest. testGetSyntaxStringWithDefaultAndStringArray
    HelperUnitTest. testGetSyntaxStringWithMandatory
    HelperUnitTest. testGetSyntaxStringWithOptionalSecondaryOptionName
    HelperUnitTest. testGetSyntaxStringWithOutMandatory
    HelperUnitTest. testGetSyntaxStringWithSecondaryOptionName
    HelperUnitTest. testGetSyntaxStringWithSecondaryOptionNameIgnored
    HelperUnitTest. testGetSyntaxStringWithSpecifiedDefault
    HelperUnitTest. testGetSyntaxStringWithStringArray
    GfshJunitTest. testWrapTest
    
    - [ ] Have you written or updated unit tests to verify your changes?
    No
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vahrama/geode feature/GEODE-3023

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/564.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #564
    
----
commit c7d3761891aa0c72a8a7a6600f653f754b38efab
Author: Vahram Aharonyan <va...@vmware.com>
Date:   2017-06-05T14:27:42Z

    GEODE-3023 TcpServer thread can be blocked in processRequest
    
    Move socket timeout setting before configureServerSSLSocket to ensure
    that SSL handshake will return in the allotted time and will not wait
    forever if other side is unresponsive.

----


> TcpServer thread can be blocked in processRequest
> -------------------------------------------------
>
>                 Key: GEODE-3023
>                 URL: https://issues.apache.org/jira/browse/GEODE-3023
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Vahram Aharonyan
>            Assignee: Udo Kohlmeyer
>             Fix For: 1.2.0
>
>
> TCP Server's main thread can be blocked in SSL handshake if client is not responsive. Socket timeout should be set before trying to configure Server's SSL Socket. This will allow server to close the connection if SSL handshake hasn't succeeded during some specified time.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)