You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/18 06:37:59 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request #13387: Delete prometheus-dcos dockerfile

michaeljmarshall opened a new pull request #13387:
URL: https://github.com/apache/pulsar/pull/13387


   ### Motivation
   
   Clean up our `docker` directory in the `pulsar` project.
   
   We have unmaintained files for a custom prometheus docker image that adds a small `prometheus.yaml` file to the `prometheus` docker image. The prometheus version in the dockerfile is `v1.8.2`. The latest version is `v2.32.0`. We haven't modified this section of the code for 3 years since its initial commit in PR #1127. Since this is unmaintained, I'd like to propose removing it from our repo.
   
   Note, we were not building or publishing the docker image created by this dockerfile.
   
   ### Modifications
   
   * Delete the `docker/prometheus-dcos` directory.
   
   ### Verifying this change
   
   We don't currently build/publish this docker image. It is possible that some users are interested in the `prometheus.yaml` file. I will send a note to the mailing list to discuss this feature's removal to make sure it is not being used.
   
   ### Does this pull request potentially affect one of the following parts:
   
   This is a deprecation of a feature that likely hasn't been used very much.
   
   ### Documentation
     
   - [x] `no-need-doc` 
     
   As far as I can tell, there are no docs related to this feature.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall merged pull request #13387: Delete prometheus-dcos dockerfile

Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged pull request #13387:
URL: https://github.com/apache/pulsar/pull/13387


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #13387: Delete prometheus-dcos dockerfile

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #13387:
URL: https://github.com/apache/pulsar/pull/13387#issuecomment-997156157


   Note that we _technically_ reference this docker image here: https://github.com/apache/pulsar/blob/c5d7a84c8e5c27e48022df8c7082496840cd3be9/deployment/dcos/PulsarGroups.json#L250-L254.
   
   However, that is a reference to a private docker repo, and not the `apachepulsar` docker repo. I just ran `docker pull zhaijia/prometheus` and it returned an image that is between 3 and 4 years old.
   
   It's possible we should remove the `deployment/dcos` directory. It was last updated in May 2018.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org