You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jens-G <gi...@git.apache.org> on 2017/11/30 23:37:15 UTC

[GitHub] thrift pull request #1431: THRIFT-4398 Update EXTRA_DIST for "make dist"

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/1431

    THRIFT-4398 Update EXTRA_DIST for "make dist"

    Client: Build process
    Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift THRIFT-4398

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1431
    
----
commit 9f44365d59693b2032393fe0807575cbb8b5384c
Author: Jens Geyer <je...@apache.org>
Date:   2017-11-30T21:30:03Z

    THRIFT-4398 Update EXTRA_DIST for "make dist"
    Client: Build process
    Patch: Jens Geyer

----


---

[GitHub] thrift pull request #1431: THRIFT-4398 Update EXTRA_DIST for "make dist"

Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1431#discussion_r154285598
  
    --- Diff: test/haxe/Makefile.am ---
    @@ -96,7 +96,9 @@ EXTRA_DIST = \
                  neko.hxml \
                  php.hxml \
                  python.hxml \
    +             router.php \
                  project.hide \
    +			 php-web-server.hxml \
    --- End diff --
    
    Thanks, fixed.


---

[GitHub] thrift pull request #1431: THRIFT-4398 Update EXTRA_DIST for "make dist"

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1431


---

[GitHub] thrift pull request #1431: THRIFT-4398 Update EXTRA_DIST for "make dist"

Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1431#discussion_r154248711
  
    --- Diff: test/haxe/Makefile.am ---
    @@ -96,7 +96,9 @@ EXTRA_DIST = \
                  neko.hxml \
                  php.hxml \
                  python.hxml \
    +             router.php \
                  project.hide \
    +			 php-web-server.hxml \
    --- End diff --
    
    indentation difference


---