You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Fang Wang <fa...@citrix.com> on 2013/08/10 02:50:04 UTC

Review Request 13459: cloudstack-3759: deployVM with state set to be stopped, attach volume to it. The volume should not be created.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13459/
-----------------------------------------------------------

Review request for cloudstack and Frank Zhang.


Bugs: cloudstack-3759


Repository: cloudstack-git


Description
-------

When deploying a new VM, with its state set to be stopped. At that time, when attaching volume to it, we need to delay the volume creation. Because in DB, the host id and pod id, fields for the VM are empty. 


Diffs
-----

  server/src/com/cloud/storage/VolumeManagerImpl.java 100aad3 

Diff: https://reviews.apache.org/r/13459/diff/


Testing
-------


Thanks,

Fang Wang


Re: Review Request 13459: cloudstack-3759: deployVM with state set to be stopped, attach volume to it. The volume should not be created.

Posted by Frank Zhang <fr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13459/#review25039
-----------------------------------------------------------


please update your test result

- Frank Zhang


On Aug. 10, 2013, 12:50 a.m., Fang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13459/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2013, 12:50 a.m.)
> 
> 
> Review request for cloudstack and Frank Zhang.
> 
> 
> Bugs: cloudstack-3759
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When deploying a new VM, with its state set to be stopped. At that time, when attaching volume to it, we need to delay the volume creation. Because in DB, the host id and pod id, fields for the VM are empty. 
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 100aad3 
> 
> Diff: https://reviews.apache.org/r/13459/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fang Wang
> 
>


Re: Review Request 13459: cloudstack-3759: deployVM with state set to be stopped, attach volume to it. The volume should not be created.

Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13459/#review25059
-----------------------------------------------------------


Review 13459 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #118 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/118/

- Jenkins Cloudstack.org


On Aug. 10, 2013, 12:50 a.m., Fang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13459/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2013, 12:50 a.m.)
> 
> 
> Review request for cloudstack and Frank Zhang.
> 
> 
> Bugs: cloudstack-3759
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When deploying a new VM, with its state set to be stopped. At that time, when attaching volume to it, we need to delay the volume creation. Because in DB, the host id and pod id, fields for the VM are empty. 
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 100aad3 
> 
> Diff: https://reviews.apache.org/r/13459/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fang Wang
> 
>