You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/26 03:34:59 UTC
[GitHub] [rocketmq] Kvicii opened a new issue #3797: DefaultMQProducerImpl code improvement
Kvicii opened a new issue #3797:
URL: https://github.com/apache/rocketmq/issues/3797
hi all,
The DefaultMQProducerImpl class has some code that can be optimized, I will provide a PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Kvicii commented on issue #3797: DefaultMQProducerImpl code improvement
Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #3797:
URL: https://github.com/apache/rocketmq/issues/3797#issuecomment-1022892174
@caigy As I said before, I think these invalid calls should be removed. For some verbose methods, we should do refactoring to ensure code readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Kvicii commented on issue #3797: DefaultMQProducerImpl code improvement
Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #3797:
URL: https://github.com/apache/rocketmq/issues/3797#issuecomment-1026859960
[PR-3809](https://github.com/apache/rocketmq/pull/3809)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] caigy commented on issue #3797: DefaultMQProducerImpl code improvement
Posted by GitBox <gi...@apache.org>.
caigy commented on issue #3797:
URL: https://github.com/apache/rocketmq/issues/3797#issuecomment-1022888981
@Kvicii Looking forward to more detailed description of this improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Kvicii edited a comment on issue #3797: DefaultMQProducerImpl code improvement
Posted by GitBox <gi...@apache.org>.
Kvicii edited a comment on issue #3797:
URL: https://github.com/apache/rocketmq/issues/3797#issuecomment-1021853991
about the checkTransactionState API, it seems that we should remove the calls to the checkListener method and TransactionCheckListener, should we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Kvicii commented on issue #3797: DefaultMQProducerImpl code improvement
Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #3797:
URL: https://github.com/apache/rocketmq/issues/3797#issuecomment-1021853991
abount the checkTransactionState API, it seems that we should remove the calls to the checkListener method and TransactionCheckListener, should we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Kvicii commented on issue #3797: DefaultMQProducerImpl code improvement
Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #3797:
URL: https://github.com/apache/rocketmq/issues/3797#issuecomment-1022893279
@caigy I'm thinking about this right now, if you can tell me when this kind of code can be removed, I'll ignore the question
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky closed issue #3797: DefaultMQProducerImpl code improvement
Posted by GitBox <gi...@apache.org>.
duhenglucky closed issue #3797:
URL: https://github.com/apache/rocketmq/issues/3797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org