You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/08 01:36:24 UTC
[kudu-CR] dist test: set death signal on forked processes
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4330
to review the following change.
Change subject: dist_test: set death signal on forked processes
......................................................................
dist_test: set death signal on forked processes
I noticed that hitting ^C after submitting a dist-test job doesn't
actually kill the subprocess which is running 'dist-test/bin/client
watch'. The 'watch' process keeps running in the background, which is
quite annoying.
This patch adds a prctl() call so that the subprocess is killed when
dist-test.py is killed.
Change-Id: I79a2c4b29a8a6b1c922c2021994ed2ea0a8cb3ba
---
M build-support/dist_test.py
1 file changed, 18 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/4330/1
--
To view, visit http://gerrit.cloudera.org:8080/4330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79a2c4b29a8a6b1c922c2021994ed2ea0a8cb3ba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] dist test: set death signal on forked processes
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: dist_test: set death signal on forked processes
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3271/
--
To view, visit http://gerrit.cloudera.org:8080/4330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79a2c4b29a8a6b1c922c2021994ed2ea0a8cb3ba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] dist test: set death signal on forked processes
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: dist_test: set death signal on forked processes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4330/1/build-support/dist_test.py
File build-support/dist_test.py:
PS1, Line 341: the child
: processes are killed as well, rather than being reparented to pid 1.
> hrm... it should be, but for some reason that's not working.
figured out the issue here.. dist_test is doing a blanket 'except:' catch during the urlopen, instead of a more specific 'except Exception:'. So, it catches the KeyboardInterrupt and keeps running. I'll make the fix there.
--
To view, visit http://gerrit.cloudera.org:8080/4330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79a2c4b29a8a6b1c922c2021994ed2ea0a8cb3ba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] dist test: set death signal on forked processes
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: dist_test: set death signal on forked processes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4330/1/build-support/dist_test.py
File build-support/dist_test.py:
PS1, Line 341: the child
: processes are killed as well, rather than being reparented to pid 1.
> Isn't the default behavior for a child to receive a SIGHUP though?
hrm... it should be, but for some reason that's not working.
--
To view, visit http://gerrit.cloudera.org:8080/4330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79a2c4b29a8a6b1c922c2021994ed2ea0a8cb3ba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] dist test: set death signal on forked processes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: dist_test: set death signal on forked processes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4330/1/build-support/dist_test.py
File build-support/dist_test.py:
PS1, Line 341: the child
: processes are killed as well, rather than being reparented to pid 1.
Isn't the default behavior for a child to receive a SIGHUP though?
--
To view, visit http://gerrit.cloudera.org:8080/4330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79a2c4b29a8a6b1c922c2021994ed2ea0a8cb3ba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] dist test: set death signal on forked processes
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has abandoned this change.
Change subject: dist_test: set death signal on forked processes
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I79a2c4b29a8a6b1c922c2021994ed2ea0a8cb3ba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>