You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by peter-gergely-horvath <gi...@git.apache.org> on 2018/07/04 18:37:59 UTC
[GitHub] nifi pull request #2842: NIFI-5318 Implement NiFi test harness: initial comm...
GitHub user peter-gergely-horvath opened a pull request:
https://github.com/apache/nifi/pull/2842
NIFI-5318 Implement NiFi test harness: initial commit of nifi-test
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
At the moment, the build fails with unit **test failures unrelated to this commit**:
```
[INFO] Running org.apache.nifi.csv.TestCSVValidators
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.018 s - in org.apache.nifi.csv.TestCSVValidators
[INFO] Running org.apache.nifi.csv.TestJacksonCSVRecordReader
[ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.033 s <<< FAILURE! - in org.apache.nifi.csv.TestJacksonCSVRecordReader
[ERROR] testUTF8(org.apache.nifi.csv.TestJacksonCSVRecordReader) Time elapsed: 0.002 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<[黃凱揚]> but was:<[???]>
at org.apache.nifi.csv.TestJacksonCSVRecordReader.testUTF8(TestJacksonCSVRecordReader.java:81)
[INFO] Running org.apache.nifi.csv.TestCSVHeaderSchemaStrategy
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 s - in org.apache.nifi.csv.TestCSVHeaderSchemaStrategy
[INFO] Running org.apache.nifi.csv.TestCSVRecordReader
[INFO] Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 s - in org.apache.nifi.csv.TestCSVRecordReader
[INFO] Running org.apache.nifi.csv.TestWriteCSVResult
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 s - in org.apache.nifi.csv.TestWriteCSVResult
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestJacksonCSVRecordReader.testUTF8:81 expected:<[黃凱揚]> but was:<[???]>
[ERROR] TestXMLReader.testAttributePrefix:133 expected:<... ATTR_ID=P3, NAME=Am[é]lie Bonfils, AGE=74}...> but was:<... ATTR_ID=P3, NAME=Am[?]lie Bonfils, AGE=74}...>
[ERROR] TestXMLReader.testContentField:156 expected:<...apRecord[{CONTENT=Am[é]lie Bonfils, ATTR=at...> but was:<...apRecord[{CONTENT=Am[?]lie Bonfils, ATTR=at...>
[INFO]
[ERROR] Tests run: 221, Failures: 3, Errors: 0, Skipped: 2
[INFO]
[INFO] ------------------------------------------------------------------------
```
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peter-gergely-horvath/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2842.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2842
----
commit 7af1eebc61d764790fb108db0bed8eb63f050b96
Author: Peter G. Horvath <pe...@...>
Date: 2018-07-04T16:33:24Z
NIFI-5318 Implement NiFi test harness: initial commit of nifi-test
----
---
[GitHub] nifi pull request #2842: NIFI-5318 Implement NiFi test harness: initial comm...
Posted by peter-gergely-horvath <gi...@git.apache.org>.
Github user peter-gergely-horvath closed the pull request at:
https://github.com/apache/nifi/pull/2842
---