[GitHub] [netbeans] matthiasblaesing edited a comment on pull request #2438: NETBEANS-4893 - Added node_modules and bower_components to the option

[GitBox <gi...@apache.org>]

matthiasblaesing edited a comment on pull request #2438:
URL: https://github.com/apache/netbeans/pull/2438#issuecomment-706744123


   @Chris2011 so this is a big hammer that helps you, but might be a problem for "normal" JS users. 
   
   I can explain why indexing in netbeans is slow: Because the JS indexer tries to deal with the mess, that is the JS ecosystem. The JS files are parsed in context and that is a dramatic slowdown.
   
   By your description your "fix" basicly breaks all index based support for every JS project, that uses npm to manage its dependencies.  The only support that is retained is typescript completion, as that is handled by the typescript language server.
   
   Given, that the side effect described above this is a -1 for me.
   
   Edit: added personal judgement.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists