You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/24 23:28:36 UTC

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #6126: [VTA][OpenCL] intelfocl

tmoreau89 commented on pull request #6126:
URL: https://github.com/apache/incubator-tvm/pull/6126#issuecomment-663772343


   Thanks @zhanghaohit. This is converging nicely. I made some additional comments.
   
   In addition, I'd like to request further partitioning given the large size of the PR.
   
   (1) the following files will need to migrate to #6125:
   - src/relay/op/annotation/annotation.cc
   - python/tvm/relay/op/_tensor.py
   
   (2) changes made for quantization should be isolated to an additional PR, this includes:
   - src/relay/quantize/realize.cc
   - python/tvm/relay/quantize/_partition.py
   - python/tvm/relay/quantize/_annotate.py


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org