You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/05/15 18:32:56 UTC
[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #3138: ARTEMIS-2766 Not parsing application properties for duplicate property
clebertsuconic opened a new pull request #3138:
URL: https://github.com/apache/activemq-artemis/pull/3138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3138: ARTEMIS-2766 Not parsing application properties for duplicate property
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3138:
URL: https://github.com/apache/activemq-artemis/pull/3138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3138: ARTEMIS-2766 Not parsing application properties for duplicate property
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3138:
URL: https://github.com/apache/activemq-artemis/pull/3138#issuecomment-629589907
@franz1981 MSG_BODY_TYPES are the types that will possibly hold data. We need that list regardless.
there's an exposed method to look for the one I need. I think this is correct. and everything seems to be working fine.
I didn't release yet BTW as I was dealing with an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3138: ARTEMIS-2766 Not parsing application properties for duplicate property
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3138:
URL: https://github.com/apache/activemq-artemis/pull/3138#issuecomment-629589019
Bud sorry that I have been able to read this just now from my phone: the IdentityHashMap (on MSG_BODY_TYPES) I have used was meant to be used to search just MessageAnnotations: you should remove any (potentially) terminal section before the one you're searching to build the right one for your use case.
In the current state of this PR if you hit a MessageAnnotations while searching for Data you will return with a false from the research of the Symbol, that's not correct.
I suggest, for simplicity, to build your own static final Identity hashmap with the correct terminal symbols for the data section (including the data section) and just expose an "anyData" search method instead of a more generic one. Another solution can be to remove the map and use some of the loops used by Robbie or Tim to do similar things, in order to exit when some terminal symbol beyond what you're expecting to find is being found.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3138: ARTEMIS-2766 Not parsing application properties for duplicate property
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3138:
URL: https://github.com/apache/activemq-artemis/pull/3138#issuecomment-629589680
ApplicationProperties.class is on the list.. I don't see a problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3138: ARTEMIS-2766 Not parsing application properties for duplicate property
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3138:
URL: https://github.com/apache/activemq-artemis/pull/3138#issuecomment-629591997
https://github.com/apache/activemq-artemis/pull/3140 will contain a fix.
Still a WIP and I will finish tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3138: ARTEMIS-2766 Not parsing application properties for duplicate property
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3138:
URL: https://github.com/apache/activemq-artemis/pull/3138#issuecomment-629591501
It wouldn't been an issue because I'm starting the search right at the position of the applicaitonProperties. But I'm fixing it for correctness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3138: ARTEMIS-2766 Not parsing application properties for duplicate property
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3138:
URL: https://github.com/apache/activemq-artemis/pull/3138#issuecomment-629590757
I see the issue.
you used that list to stop the loop... you didn't want to keep looking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org