[GitHub] rhtyd commented on a change in pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

[gi...@git.apache.org]

rhtyd commented on a change in pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#discussion_r114709474
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/com/cloud/ha/KVMInvestigator.java
 ##########
 @@ -40,17 +40,23 @@
 public class KVMInvestigator extends AdapterBase implements Investigator {
     private final static Logger s_logger = Logger.getLogger(KVMInvestigator.class);
     @Inject
-    HostDao _hostDao;
+    private HostDao _hostDao;
+    @Inject
+    private AgentManager _agentMgr;
     @Inject
-    AgentManager _agentMgr;
+    private ResourceManager _resourceMgr;
     @Inject
-    ResourceManager _resourceMgr;
+    private PrimaryDataStoreDao _storagePoolDao;
     @Inject
-    PrimaryDataStoreDao _storagePoolDao;
+    private HAManager haManager;
 
     @Override
     public boolean isVmAlive(com.cloud.vm.VirtualMachine vm, Host host) throws UnknownVM {
+        if (haManager.isHAEligible(host)) {
 
 Review comment:
   @koushik-das FYI - injections here for VM-HA Host-HA coordination, the eligibility checks several things -- including that the feature is explicitly enabled for a host.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services