You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/12 01:53:36 UTC

[GitHub] [skywalking-php] jmjoy commented on a diff in pull request #16: Fix package.xml role error

jmjoy commented on code in PR #16:
URL: https://github.com/apache/skywalking-php/pull/16#discussion_r992909380


##########
package.tpl.xml:
##########
@@ -55,7 +55,7 @@ limitations under the License.
 	</notes>
 	<contents>
 		<dir name="/">
-			{% for file in files %}<file role="src" name="{{ file.path }}" />

Review Comment:
   Why not just make role as an placeholder, instead of using filter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org