[jira] Updated: (WICKET-3135) Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()

["Sverre Boschman (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sverre Boschman updated WICKET-3135:
------------------------------------

    Attachment: test-WICKET-3135.patch

Actually it is not the toString() from JavascriptPackageResource that is causing the problem for the requestlogger. It is the toString() from the underlying resourcestream.

Two output examples of the requestlogger:
[ResourceStreamRequestTarget[resourceStream=org.apache.wicket.markup.html.JavascriptPackageResource$2@3796a671,fileName=null]
[ResourceStreamRequestTarget[resourceStream=jar:file://wickext/resources/auto/ui.autocomplete.css,fileName=null]

Both resources are served by a ResourceStreamRequestTarget, which does a resourceStream.toString() to generate the requestlog output in its own toString() method. The FilteringResourceStream and CompressingResourceStream used for the javascript resources do not implement a toString() and are responsible for the stream hashcode in the requestlogger.



> Improve JavaScriptPackageResource#toString() to show filename instead of default Object#toString()
> --------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3135
>                 URL: https://issues.apache.org/jira/browse/WICKET-3135
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.13
>            Reporter: Martijn Dashorst
>            Assignee: Martin Grigorov
>             Fix For: 1.4.14, 1.5-M4
>
>         Attachments: test-WICKET-3135.patch
>
>
> For seeing the difference between normal page requests (and ajax requests) and resource request, the requestlogger needs to output the actual filename of the resource. This allows for a top 10 most requested resources...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.