You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Chesnay Schepler (Jira)" <ji...@apache.org> on 2022/10/11 14:22:00 UTC

[jira] [Comment Edited] (FLINK-29563) SourceTestSuiteBase#testSourceMetrics enters an infinite waiting loop in case the number of records counter is wrong

    [ https://issues.apache.org/jira/browse/FLINK-29563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615858#comment-17615858 ] 

Chesnay Schepler edited comment on FLINK-29563 at 10/11/22 2:21 PM:
--------------------------------------------------------------------

??As a more general comment, maybe we should introduce junit tags to specify tests targeted to unbounded sources and dynamically ignore them for bounded sources. Chesnay Schepler WDYT ? Should I create a new ticket for that ???

ehhh I'm not a fan of that. So far we only used categories/tags for exceptional circumstances, like known bugs or incompatibilities (e.g., java 11).

Why is it relevant whether the source is bounded or not for this test?


was (Author: zentol):
> As a more general comment, maybe we should introduce junit tags to specify tests targeted to unbounded sources and dynamically ignore them for bounded sources. Chesnay Schepler WDYT ? Should I create a new ticket for that ?

ehhh I'm not a fan of that. So far we only used categories/tags for exceptional circumstances, like known bugs or incompatibilities (e.g., java 11).

Why is it relevant whether the source is bounded or not for this test?

> SourceTestSuiteBase#testSourceMetrics enters an infinite waiting loop in case the number of records counter is wrong
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-29563
>                 URL: https://issues.apache.org/jira/browse/FLINK-29563
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Etienne Chauchot
>            Assignee: Etienne Chauchot
>            Priority: Major
>
> The call to _CommonTestUtils#waitUntilCondition_ (1) makes the test wait for the condition _Precision.equals(allRecordSize, sumNumRecordsIn)_. In case the reported number of records is incorrect, the waiting loop never ends.
> [1] https://github.com/apache/flink/blob/a6092b1176d15a7af32a7eb19f59cdfeab172034/flink-test-utils-parent/flink-connector-test-utils/src/main/java/org/apache/flink/connector/testframe/testsuites/SourceTestSuiteBase.java#L451 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)