You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2016/12/20 12:31:21 UTC
[GitHub] kafka pull request #2280: KAFKA-4554: Fix `ReplicaBuffer.verifyChecksum` to ...
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/2280
KAFKA-4554: Fix `ReplicaBuffer.verifyChecksum` to use iterators instead of iterables
This was changed in b58b6a1bef0 and caused the `ReplicaVerificationToolTest.test_replica_lags`
system test to start failing.
I also added a unit test and a couple of other minor clean-ups.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka kafka-4554-fix-replica-buffer-verify-checksum
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2280
----
commit f85d8c46eb22b88f26b8f6219f8287c8544f9cf9
Author: Ismael Juma <is...@juma.me.uk>
Date: 2016-12-20T12:26:25Z
Remove `JTestUtils.partitionRecordsBuffer` in favour of `MemoryRecords.withRecords`
commit 185e9048d282ba6e68ba55594aa13568d0f2d035
Author: Ismael Juma <is...@juma.me.uk>
Date: 2016-12-20T12:27:33Z
Fix regression in `verifyChecksum` where iterators had incorrectly been replaced by iterables
Also add unit test.
commit 3ddfad07bbf064ff90a3856c7a8233e4e20d8222
Author: Ismael Juma <is...@juma.me.uk>
Date: 2016-12-20T12:28:27Z
Use `long` instead of `Long` in `KafkaStreamsTest.onChange`
Fixes a compilation failure when compiling in IntelliJ with Java 8.
Not sure why, but `long` is better than `Long` in this case anyway.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #2280: KAFKA-4554: Fix ReplicaBuffer.verifyChecksum to us...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/2280
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---