You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/03 20:38:08 UTC
[GitHub] zheng-da commented on a change in pull request #12008: [WIP] Enable
graph partitioning in executor with types/shape awareness
zheng-da commented on a change in pull request #12008: [WIP] Enable graph partitioning in executor with types/shape awareness
URL: https://github.com/apache/incubator-mxnet/pull/12008#discussion_r207660533
##########
File path: src/operator/subgraph/default_subgraph_op.h
##########
@@ -35,18 +36,19 @@ namespace op {
*/
class SubgraphSelector {
public:
- virtual ~SubgraphSelector() {
- }
+ virtual ~SubgraphSelector() {}
// Determine if the node should be selected for a subgraph.
- virtual bool Select(const nnvm::Node &n) = 0;
+ virtual bool Select(const nnvm::Graph *g, const nnvm::Node &n) = 0;
Review comment:
it's better to be a graph reference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services