You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@groovy.apache.org by Pascal Schumacher <pa...@gmx.net> on 2016/02/03 18:12:35 UTC

Should the pull request for "GROOVY-7735 - Closures should be generated as public classes" be merged?

Hello everyone,

any objections to a merge of: https://github.com/apache/groovy/pull/248

Requested in https://issues.apache.org/jira/browse/GROOVY-7735 ?

Cheers,
Pascal

Re: Should the pull request for "GROOVY-7735 - Closures should be generated as public classes" be merged?

Posted by Pascal Schumacher <pa...@gmx.net>.
done

Am 08.02.2016 um 08:23 schrieb Jochen Theodorou:
> I am thinking we could do it for both. If then 2.4.6 breaks we will 
> have to undo the change and I prefer knowing this now, than in a 2.5.x 
> version
>
> bye Jochen
>

Re: Should the pull request for "GROOVY-7735 - Closures should be generated as public classes" be merged?

Posted by Jochen Theodorou <bl...@gmx.org>.
On 06.02.2016 10:16, Pascal Schumacher wrote:
> sure
>
> should this be in 2.4.6, or master only?
>
> Am 06.02.2016 um 09:15 schrieb Jochen Theodorou:
>> On 03.02.2016 18:12, Pascal Schumacher wrote:
>>> Hello everyone,
>>>
>>> any objections to a merge of: https://github.com/apache/groovy/pull/248
>>>
>>> Requested in https://issues.apache.org/jira/browse/GROOVY-7735 ?
>> there has been none so far, so I suggest to make the change

I am thinking we could do it for both. If then 2.4.6 breaks we will have 
to undo the change and I prefer knowing this now, than in a 2.5.x version

bye Jochen

Re: Should the pull request for "GROOVY-7735 - Closures should be generated as public classes" be merged?

Posted by Pascal Schumacher <pa...@gmx.net>.
sure

should this be in 2.4.6, or master only?

Am 06.02.2016 um 09:15 schrieb Jochen Theodorou:
> On 03.02.2016 18:12, Pascal Schumacher wrote:
>> Hello everyone,
>>
>> any objections to a merge of: https://github.com/apache/groovy/pull/248
>>
>> Requested in https://issues.apache.org/jira/browse/GROOVY-7735 ?
> there has been none so far, so I suggest to make the change
>
> bye Jochen
>

Re: Should the pull request for "GROOVY-7735 - Closures should be generated as public classes" be merged?

Posted by Jochen Theodorou <bl...@gmx.org>.
On 03.02.2016 18:12, Pascal Schumacher wrote:
> Hello everyone,
>
> any objections to a merge of: https://github.com/apache/groovy/pull/248
>
> Requested in https://issues.apache.org/jira/browse/GROOVY-7735 ?
there has been none so far, so I suggest to make the change

bye Jochen