[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7051: chore(deps): update sqlparser requirement from 0.35 to 0.36.1

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #7051:
URL: https://github.com/apache/arrow-datafusion/pull/7051#discussion_r1270703632


##########
datafusion/core/src/execution/context.rs:
##########
@@ -2175,13 +2175,13 @@ mod tests {
     async fn create_variable_err() -> Result<()> {
         let ctx = SessionContext::new();
 
-        let err = plan_and_collect(&ctx, "SElECT @=   X#=?!~ 5")

Review Comment:
   without chis change, sqlparser complains (reasonably) about `X#=?!~ 5` not being a valid identifier. 
   
   https://github.com/apache/arrow-datafusion/actions/runs/5621460600/job/15232281958?pr=7051
   
   ```
   ---- execution::context::tests::create_variable_err stdout ----
   thread 'execution::context::tests::create_variable_err' panicked at 'assertion failed: `(left == right)`
     left: `"SQL error: ParserError(\"Expected end of statement, found: =\")"`,
    right: `"Error during planning: variable [\"@\"] has no type information"`', datafusion/core/src/execution/context.rs:2182:9
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   
   ```
   
   So I changed the test to preserver the error (rather than updating the error to be a parse error)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org