You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "golja (via GitHub)" <gi...@apache.org> on 2025/12/12 19:49:25 UTC
[PR] Fix various bugs in receive against po [ofbiz-framework]
golja opened a new pull request, #932:
URL: https://github.com/apache/ofbiz-framework/pull/932
Fixed: Ensure shipGroupSeqId is correctly set in context and passed to the template.
Display order items quantities for the selected ship group.
Make Order ID and Ship Group ID read-only fields and remove Shipment ID field in the Receive Against PO screen, because the screen is one of the sub-tabs of the shipment screen.
Add logic to filter shipment receipts by ship group, in order to properly display receive quantity in the Receive Against PO screen, in case of order items split into multiple ship groups.
Fix bug that causes creation of shipment receipt records with shipment id, but no shipment item sequence id
Explanation: various bugs were discovered when receiving an order item split into more than one ship group, by means of the Receive Against PO screen. The PR fixes those regarding the correct determination and visualization of quantities per ship group, e.g., 'order', 'received', etc.
There are still outstanding bugs in the trunk, such as the 'Force Complete Purchase Order' that still doesn't support order items split into multiple ship groups, wrong invoice creation, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: various bugs in receive against purchase orders (OFBIZ-13327) [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932#issuecomment-3689681950
Thanks Anahita,
I guess I clicked on the wrong line then. I remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: various bugs in receive against purchase orders (OFBIZ-13327) [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932#issuecomment-3649080642
I have created https://issues.apache.org/jira/browse/OFBIZ-13327 related to this PR
As I said there not sure there will be subtasks or not
>This Jira issue is created as either an umbrella task with later subtasks or possibly a simple bugs fixes issues in relation with PR-932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: various bugs in receive against purchase orders (OFBIZ-13327) [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932#issuecomment-3656495144
Hi Anahita,
I tested the Receive Against PO screen and the result in the main order screen and I did not find any issues. I received respectively 8 on 10 (shipment 2) and 5 on 7 (shipment 1). Of course I did not use the 'Force Complete Purchase Order' as we known it's deficient.
I just want to mention that https://issues.apache.org/jira/browse/OFBIZ-9592 Paul is working on an enhancement of the main order screen. There should not be any interaction at this stage, just mentioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix various bugs in receive against po [ofbiz-framework]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932#issuecomment-3647922120
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=932) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=932&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=932&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=932&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=932&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=932&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=932)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: various bugs in receive against purchase orders (OFBIZ-13327) [ofbiz-framework]
Posted by "golja (via GitHub)" <gi...@apache.org>.
golja commented on PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932#issuecomment-3689547932
Hi Jacques,
I didn't request Gil's review. From the logs above it seems that you added him as a reviewer 2 weeks ago.
Anahita
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: various bugs in receive against purchase orders (OFBIZ-13327) [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932#issuecomment-3689418060
Hi Anahita,
No I don't know. I guess he will get the message and answer himself. BTW, did you ask for his review or did he pick it himself?
Have fun too 😄 ❄️.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: various bugs in receive against purchase orders (OFBIZ-13327) [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932#issuecomment-3689683877
Do you need more time before pushing this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: various bugs in receive against purchase orders (OFBIZ-13327) [ofbiz-framework]
Posted by "golja (via GitHub)" <gi...@apache.org>.
golja commented on PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932#issuecomment-3689381507
Hi @JacquesLeRoux,
do you know if @gilPts is willing to review the PR?
Thanks and happy holidays
Anahita
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: various bugs in receive against purchase orders (OFBIZ-13327) [ofbiz-framework]
Posted by "golja (via GitHub)" <gi...@apache.org>.
golja commented on PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932#issuecomment-3649160058
Thank you, @JacquesLeRoux (Hi @gilPts !)
Let me know if you need any clarification on the changes.
Anahita
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: various bugs in receive against purchase orders (OFBIZ-13327) [ofbiz-framework]
Posted by "golja (via GitHub)" <gi...@apache.org>.
golja commented on PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932#issuecomment-3659658903
Hi Jacques,
thank you for the test and the review. And thank you for pointing out Paul's work.
Just so you know, I'm already working on fixing the 'Force Complete Purchase Order' button behavior and I'm almost done.
As soon as this pull request will be merged, I'll submit another PR for that fix.
Have a good day
Anahita
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: various bugs in receive against purchase orders (OFBIZ-13327) [ofbiz-framework]
Posted by "golja (via GitHub)" <gi...@apache.org>.
golja commented on PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932#issuecomment-3690307737
No, Jacques, thank you. I have already thoroughly tested the changes, and I am comfortable with them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: various bugs in receive against purchase orders (OFBIZ-13327) [ofbiz-framework]
Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux merged PR #932:
URL: https://github.com/apache/ofbiz-framework/pull/932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org