You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by ad...@apache.org on 2015/11/30 10:22:05 UTC
svn commit: r1717211 - /xmlgraphics/fop/trunk/findbugs-exclude.xml
Author: adelmelle
Date: Mon Nov 30 09:22:05 2015
New Revision: 1717211
URL: http://svn.apache.org/viewvc?rev=1717211&view=rev
Log:
Add approved exclusion for two warnings
Modified:
xmlgraphics/fop/trunk/findbugs-exclude.xml
Modified: xmlgraphics/fop/trunk/findbugs-exclude.xml
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/findbugs-exclude.xml?rev=1717211&r1=1717210&r2=1717211&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/findbugs-exclude.xml (original)
+++ xmlgraphics/fop/trunk/findbugs-exclude.xml Mon Nov 30 09:22:05 2015
@@ -48,6 +48,14 @@
<!-- START - APPROVED EXCLUSIONS -->
<Match>
+ <Bug pattern="ES_COMPARING_STRINGS_WITH_EQ"/>
+ <!-- OK; check mainly serves to cover case where both strings are null -->
+ <And>
+ <Class name="org.apache.fop.afp.AFPResourceInfo"/>
+ <Method name="equals"/>
+ </And>
+ </Match>
+ <Match>
<Bug pattern="BC_BAD_CAST_TO_CONCRETE_COLLECTION"/>
<!-- TODO - Not sure what to do with those two... Seems messy/hacky -->
<And>
@@ -97,6 +105,72 @@
</Or>
</Match>
<Match>
+ <Bug pattern="DM_DEFAULT_ENCODING"/>
+ <Or>
+ <!-- default encoding used as a fallback/last resort -->
+ <Or>
+ <And>
+ <Method name="getNameBytes"/>
+ <Or>
+ <Class name="org.apache.fop.afp.fonts.CharacterSet"/>
+ <Class name="org.apache.fop.afp.modca.AbstractNamedAFPObject"/>
+ </Or>
+ </And>
+ <And>
+ <Class name="org.apache.fop.pdf.PDFDocument"/>
+ <Method name="encode"/>
+ </And>
+ </Or>
+ <!-- reads from or writes to terminal/console -->
+ <Or>
+ <And>
+ <Class name="org.apache.fop.fonts.autodetect.WindowsFontDirFinder"/>
+ <Method name="getWinDir"/>
+ </And>
+ <And>
+ <Class name="org.apache.fop.hyphenation.HyphenationTree"/>
+ <Method name="main"/>
+ </And>
+ <And>
+ <Class name="org.apache.fop.render.rtf.rtflib.RtfFile"/>
+ <Method name="main"/>
+ </And>
+ </Or>
+ <!-- private method: byte-to-string and string-to-byte always on the same platform -->
+ <And>
+ <Class name="org.apache.fop.render.afp.AFPPainter$AFPBorderPainterAdapter"/>
+ <Method name="hash"/>
+ </And>
+ <!-- source encoding out of FOP's control (FontBox) -->
+ <Or>
+ <And>
+ <Class name="org.apache.fop.fonts.cff.CFFDataReader"/>
+ <Method name="getString"/>
+ </And>
+ <And>
+ <Class name="org.apache.fop.fonts.truetype.OTFSubSetFile"/>
+ <Or>
+ <Method name="createCFF"/>
+ <Method name="writeROSEntry"/>
+ <Method name="writeStringIndex"/>
+ </Or>
+ </And>
+ <And>
+ <Class name="org.apache.fop.render.ps.PSFontUtils"/>
+ <Method name="embedType2CFF"/>
+ </And>
+ </Or>
+ </Or>
+ </Match>
+ <Match>
+ <!-- class only used when building? -->
+ <Bug pattern="OS_OPEN_STREAM_EXCEPTION_PATH"/>
+ <And>
+ <Class name="org.apache.fop.hyphenation.SerializeHyphPattern"/>
+ <Method name="serializeFile"/>
+ </And>
+ </Match>
+ <Match>
<Bug pattern="DM_EXIT"/>
<Or>
<And>
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org