You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Havret <h4...@gmail.com> on 2020/08/16 17:35:54 UTC
[VOTE] Release activemq-nms-openwire 1.8.0-rc1
Hi All,
I have put together a release of activemq-nms-openwire, please
check it and vote accordingly.
This release brings .NET Standard 2.0 support.
The files can be grabbed from:
https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/1.8.0-rc1/
Regards,
Krzysztof
Re: [VOTE] Release activemq-nms-openwire 1.8.0-rc1
Posted by Michael André Pearce <mi...@me.com.INVALID>.
Test cases for nms openwire are currently focussed on testing against activemq classic, with sql backend, thus you should have a testdbconfig also.
There is no change in these setups for testing that from previous releases. This has mostly just been a update in .net support.
Sent from my iPad
> On 25 Aug 2020, at 18:52, W B D <wb...@users.sourceforge.net> wrote:
>
> I've already built it, no problem there, but some tests are failing
> (Windows 10, Visual Studio 2019 16.7.1):
>
> - First two failed tests are AMQRedeliveryPolicyTest and
> BrokerToNMSExceptionsTest, maybe because my local test broker is Artemis
> rather than Classic? That doesn't mean it's incompatible with Artemis, but
> that some tests may be assuming Classic behaviour.
> - Several other failed tests reference a missing config
> file C:\WINDOWS\System32\test\TestDbConfig.xml in the error message - not
> sure what that's about.
>
>
>> On Mon, Aug 24, 2020 at 10:00 PM Havret <h4...@gmail.com> wrote:
>>
>> No, I don't think so. For what it's worth you could just take the binaries
>> I created for rc1 attempt, and start testing against that.
>>
>>> On Tue, Aug 25, 2020 at 12:16 AM W B D <wb...@users.sourceforge.net> wrote:
>>>
>>> If I am targeting Windows, are there any changes expected that would
>> affect
>>> me, or are they just Linux related packaging / file permissions + some
>>> issues in the text of the LICENSE and NOTICE files? If that's all it is,
>>> I'm thinking perhaps I will get the jump on this by building from source
>>> and testing already.
>>>
>>>> On Sun, Aug 23, 2020 at 2:20 PM Havret <h4...@gmail.com> wrote:
>>>
>>>> It will, but I will need to find some time to go through Robbie's
>>> remarks.
>>>>
>>>> On Sun, Aug 23, 2020 at 10:29 PM W B D <wb...@users.sourceforge.net>
>>> wrote:
>>>>
>>>>> Will there be an RC2 or a release forthcoming? I ported to .NET Core
>>> last
>>>>> spring, currently using William D Cossey's fork, which is a straight
>>> port
>>>>> of 1.7.x to NetStd. Looking forward to switch back to the newly
>>>> refactored
>>>>> official version once it's stabilized and ready to test.
>>>>>
>>>>> On Mon, Aug 17, 2020 at 8:26 AM Havret <h4...@gmail.com> wrote:
>>>>>
>>>>>> Thanks, Robbie. I'm canceling the vote then.
>>>>>>
>>>>>> On Mon, Aug 17, 2020 at 4:26 PM Robbie Gemmell <
>>>> robbie.gemmell@gmail.com
>>>>>>
>>>>>> wrote:
>>>>>>
>>>>>>> -1 (non-binding)
>>>>>>>
>>>>>>> The zip has similar permission issues seen on prior NMS related
>>>>>>> candidates when extracting on Linux, meaning you can extract the
>>> zip
>>>>>>> but then can't simply delete the resulting content (which would
>>> again
>>>>>>> be easier if contained in a subdir).
>>>>>>>
>>>>>>> The LICENCE file looks to include various cruft it shouldn't (in
>>>>>>> particular various Java stuff sticks out, plus there are multiple
>>>>>>> needless copies of the ALv2...seems like a lot of this isnt NMS
>>>>>>> relevant).
>>>>>>>
>>>>>>> The NOTICE file needs its years updated, component name fixed,
>> the
>>>>>>> silly header removed, and perhaps the content looked at for
>>> accuracy
>>>>>>> (is that referenced component actually included, not clear it
>> is?)
>>>>>>>
>>>>>>> I also dont see a tag relating to the vote. There were some
>>>>>>> release-related source changes made in the source repo after the
>>>>>>> archives were added to dist dev area, though I think those were
>> in
>>>> the
>>>>>>> archive? They'd need to be if required to recreate the release
>>> bits.
>>>> A
>>>>>>> tag should exist for whats in it either way.
>>>>>>>
>>>>>>> Robbie
>>>>>>>
>>>>>>> On Sun, 16 Aug 2020 at 18:36, Havret <h4...@gmail.com> wrote:
>>>>>>>>
>>>>>>>> Hi All,
>>>>>>>>
>>>>>>>> I have put together a release of activemq-nms-openwire, please
>>>>>>>> check it and vote accordingly.
>>>>>>>>
>>>>>>>> This release brings .NET Standard 2.0 support.
>>>>>>>>
>>>>>>>> The files can be grabbed from:
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/1.8.0-rc1/
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Krzysztof
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
Re: [VOTE] Release activemq-nms-openwire 1.8.0-rc1
Posted by W B D <wb...@users.sourceforge.net>.
I've already built it, no problem there, but some tests are failing
(Windows 10, Visual Studio 2019 16.7.1):
- First two failed tests are AMQRedeliveryPolicyTest and
BrokerToNMSExceptionsTest, maybe because my local test broker is Artemis
rather than Classic? That doesn't mean it's incompatible with Artemis, but
that some tests may be assuming Classic behaviour.
- Several other failed tests reference a missing config
file C:\WINDOWS\System32\test\TestDbConfig.xml in the error message - not
sure what that's about.
On Mon, Aug 24, 2020 at 10:00 PM Havret <h4...@gmail.com> wrote:
> No, I don't think so. For what it's worth you could just take the binaries
> I created for rc1 attempt, and start testing against that.
>
> On Tue, Aug 25, 2020 at 12:16 AM W B D <wb...@users.sourceforge.net> wrote:
>
> > If I am targeting Windows, are there any changes expected that would
> affect
> > me, or are they just Linux related packaging / file permissions + some
> > issues in the text of the LICENSE and NOTICE files? If that's all it is,
> > I'm thinking perhaps I will get the jump on this by building from source
> > and testing already.
> >
> > On Sun, Aug 23, 2020 at 2:20 PM Havret <h4...@gmail.com> wrote:
> >
> > > It will, but I will need to find some time to go through Robbie's
> > remarks.
> > >
> > > On Sun, Aug 23, 2020 at 10:29 PM W B D <wb...@users.sourceforge.net>
> > wrote:
> > >
> > > > Will there be an RC2 or a release forthcoming? I ported to .NET Core
> > last
> > > > spring, currently using William D Cossey's fork, which is a straight
> > port
> > > > of 1.7.x to NetStd. Looking forward to switch back to the newly
> > > refactored
> > > > official version once it's stabilized and ready to test.
> > > >
> > > > On Mon, Aug 17, 2020 at 8:26 AM Havret <h4...@gmail.com> wrote:
> > > >
> > > > > Thanks, Robbie. I'm canceling the vote then.
> > > > >
> > > > > On Mon, Aug 17, 2020 at 4:26 PM Robbie Gemmell <
> > > robbie.gemmell@gmail.com
> > > > >
> > > > > wrote:
> > > > >
> > > > > > -1 (non-binding)
> > > > > >
> > > > > > The zip has similar permission issues seen on prior NMS related
> > > > > > candidates when extracting on Linux, meaning you can extract the
> > zip
> > > > > > but then can't simply delete the resulting content (which would
> > again
> > > > > > be easier if contained in a subdir).
> > > > > >
> > > > > > The LICENCE file looks to include various cruft it shouldn't (in
> > > > > > particular various Java stuff sticks out, plus there are multiple
> > > > > > needless copies of the ALv2...seems like a lot of this isnt NMS
> > > > > > relevant).
> > > > > >
> > > > > > The NOTICE file needs its years updated, component name fixed,
> the
> > > > > > silly header removed, and perhaps the content looked at for
> > accuracy
> > > > > > (is that referenced component actually included, not clear it
> is?)
> > > > > >
> > > > > > I also dont see a tag relating to the vote. There were some
> > > > > > release-related source changes made in the source repo after the
> > > > > > archives were added to dist dev area, though I think those were
> in
> > > the
> > > > > > archive? They'd need to be if required to recreate the release
> > bits.
> > > A
> > > > > > tag should exist for whats in it either way.
> > > > > >
> > > > > > Robbie
> > > > > >
> > > > > > On Sun, 16 Aug 2020 at 18:36, Havret <h4...@gmail.com> wrote:
> > > > > > >
> > > > > > > Hi All,
> > > > > > >
> > > > > > > I have put together a release of activemq-nms-openwire, please
> > > > > > > check it and vote accordingly.
> > > > > > >
> > > > > > > This release brings .NET Standard 2.0 support.
> > > > > > >
> > > > > > > The files can be grabbed from:
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/1.8.0-rc1/
> > > > > > >
> > > > > > > Regards,
> > > > > > > Krzysztof
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] Release activemq-nms-openwire 1.8.0-rc1
Posted by Havret <h4...@gmail.com>.
No, I don't think so. For what it's worth you could just take the binaries
I created for rc1 attempt, and start testing against that.
On Tue, Aug 25, 2020 at 12:16 AM W B D <wb...@users.sourceforge.net> wrote:
> If I am targeting Windows, are there any changes expected that would affect
> me, or are they just Linux related packaging / file permissions + some
> issues in the text of the LICENSE and NOTICE files? If that's all it is,
> I'm thinking perhaps I will get the jump on this by building from source
> and testing already.
>
> On Sun, Aug 23, 2020 at 2:20 PM Havret <h4...@gmail.com> wrote:
>
> > It will, but I will need to find some time to go through Robbie's
> remarks.
> >
> > On Sun, Aug 23, 2020 at 10:29 PM W B D <wb...@users.sourceforge.net>
> wrote:
> >
> > > Will there be an RC2 or a release forthcoming? I ported to .NET Core
> last
> > > spring, currently using William D Cossey's fork, which is a straight
> port
> > > of 1.7.x to NetStd. Looking forward to switch back to the newly
> > refactored
> > > official version once it's stabilized and ready to test.
> > >
> > > On Mon, Aug 17, 2020 at 8:26 AM Havret <h4...@gmail.com> wrote:
> > >
> > > > Thanks, Robbie. I'm canceling the vote then.
> > > >
> > > > On Mon, Aug 17, 2020 at 4:26 PM Robbie Gemmell <
> > robbie.gemmell@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > -1 (non-binding)
> > > > >
> > > > > The zip has similar permission issues seen on prior NMS related
> > > > > candidates when extracting on Linux, meaning you can extract the
> zip
> > > > > but then can't simply delete the resulting content (which would
> again
> > > > > be easier if contained in a subdir).
> > > > >
> > > > > The LICENCE file looks to include various cruft it shouldn't (in
> > > > > particular various Java stuff sticks out, plus there are multiple
> > > > > needless copies of the ALv2...seems like a lot of this isnt NMS
> > > > > relevant).
> > > > >
> > > > > The NOTICE file needs its years updated, component name fixed, the
> > > > > silly header removed, and perhaps the content looked at for
> accuracy
> > > > > (is that referenced component actually included, not clear it is?)
> > > > >
> > > > > I also dont see a tag relating to the vote. There were some
> > > > > release-related source changes made in the source repo after the
> > > > > archives were added to dist dev area, though I think those were in
> > the
> > > > > archive? They'd need to be if required to recreate the release
> bits.
> > A
> > > > > tag should exist for whats in it either way.
> > > > >
> > > > > Robbie
> > > > >
> > > > > On Sun, 16 Aug 2020 at 18:36, Havret <h4...@gmail.com> wrote:
> > > > > >
> > > > > > Hi All,
> > > > > >
> > > > > > I have put together a release of activemq-nms-openwire, please
> > > > > > check it and vote accordingly.
> > > > > >
> > > > > > This release brings .NET Standard 2.0 support.
> > > > > >
> > > > > > The files can be grabbed from:
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/1.8.0-rc1/
> > > > > >
> > > > > > Regards,
> > > > > > Krzysztof
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] Release activemq-nms-openwire 1.8.0-rc1
Posted by W B D <wb...@users.sourceforge.net>.
If I am targeting Windows, are there any changes expected that would affect
me, or are they just Linux related packaging / file permissions + some
issues in the text of the LICENSE and NOTICE files? If that's all it is,
I'm thinking perhaps I will get the jump on this by building from source
and testing already.
On Sun, Aug 23, 2020 at 2:20 PM Havret <h4...@gmail.com> wrote:
> It will, but I will need to find some time to go through Robbie's remarks.
>
> On Sun, Aug 23, 2020 at 10:29 PM W B D <wb...@users.sourceforge.net> wrote:
>
> > Will there be an RC2 or a release forthcoming? I ported to .NET Core last
> > spring, currently using William D Cossey's fork, which is a straight port
> > of 1.7.x to NetStd. Looking forward to switch back to the newly
> refactored
> > official version once it's stabilized and ready to test.
> >
> > On Mon, Aug 17, 2020 at 8:26 AM Havret <h4...@gmail.com> wrote:
> >
> > > Thanks, Robbie. I'm canceling the vote then.
> > >
> > > On Mon, Aug 17, 2020 at 4:26 PM Robbie Gemmell <
> robbie.gemmell@gmail.com
> > >
> > > wrote:
> > >
> > > > -1 (non-binding)
> > > >
> > > > The zip has similar permission issues seen on prior NMS related
> > > > candidates when extracting on Linux, meaning you can extract the zip
> > > > but then can't simply delete the resulting content (which would again
> > > > be easier if contained in a subdir).
> > > >
> > > > The LICENCE file looks to include various cruft it shouldn't (in
> > > > particular various Java stuff sticks out, plus there are multiple
> > > > needless copies of the ALv2...seems like a lot of this isnt NMS
> > > > relevant).
> > > >
> > > > The NOTICE file needs its years updated, component name fixed, the
> > > > silly header removed, and perhaps the content looked at for accuracy
> > > > (is that referenced component actually included, not clear it is?)
> > > >
> > > > I also dont see a tag relating to the vote. There were some
> > > > release-related source changes made in the source repo after the
> > > > archives were added to dist dev area, though I think those were in
> the
> > > > archive? They'd need to be if required to recreate the release bits.
> A
> > > > tag should exist for whats in it either way.
> > > >
> > > > Robbie
> > > >
> > > > On Sun, 16 Aug 2020 at 18:36, Havret <h4...@gmail.com> wrote:
> > > > >
> > > > > Hi All,
> > > > >
> > > > > I have put together a release of activemq-nms-openwire, please
> > > > > check it and vote accordingly.
> > > > >
> > > > > This release brings .NET Standard 2.0 support.
> > > > >
> > > > > The files can be grabbed from:
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/1.8.0-rc1/
> > > > >
> > > > > Regards,
> > > > > Krzysztof
> > > >
> > >
> >
>
Re: [VOTE] Release activemq-nms-openwire 1.8.0-rc1
Posted by Havret <h4...@gmail.com>.
It will, but I will need to find some time to go through Robbie's remarks.
On Sun, Aug 23, 2020 at 10:29 PM W B D <wb...@users.sourceforge.net> wrote:
> Will there be an RC2 or a release forthcoming? I ported to .NET Core last
> spring, currently using William D Cossey's fork, which is a straight port
> of 1.7.x to NetStd. Looking forward to switch back to the newly refactored
> official version once it's stabilized and ready to test.
>
> On Mon, Aug 17, 2020 at 8:26 AM Havret <h4...@gmail.com> wrote:
>
> > Thanks, Robbie. I'm canceling the vote then.
> >
> > On Mon, Aug 17, 2020 at 4:26 PM Robbie Gemmell <robbie.gemmell@gmail.com
> >
> > wrote:
> >
> > > -1 (non-binding)
> > >
> > > The zip has similar permission issues seen on prior NMS related
> > > candidates when extracting on Linux, meaning you can extract the zip
> > > but then can't simply delete the resulting content (which would again
> > > be easier if contained in a subdir).
> > >
> > > The LICENCE file looks to include various cruft it shouldn't (in
> > > particular various Java stuff sticks out, plus there are multiple
> > > needless copies of the ALv2...seems like a lot of this isnt NMS
> > > relevant).
> > >
> > > The NOTICE file needs its years updated, component name fixed, the
> > > silly header removed, and perhaps the content looked at for accuracy
> > > (is that referenced component actually included, not clear it is?)
> > >
> > > I also dont see a tag relating to the vote. There were some
> > > release-related source changes made in the source repo after the
> > > archives were added to dist dev area, though I think those were in the
> > > archive? They'd need to be if required to recreate the release bits. A
> > > tag should exist for whats in it either way.
> > >
> > > Robbie
> > >
> > > On Sun, 16 Aug 2020 at 18:36, Havret <h4...@gmail.com> wrote:
> > > >
> > > > Hi All,
> > > >
> > > > I have put together a release of activemq-nms-openwire, please
> > > > check it and vote accordingly.
> > > >
> > > > This release brings .NET Standard 2.0 support.
> > > >
> > > > The files can be grabbed from:
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/1.8.0-rc1/
> > > >
> > > > Regards,
> > > > Krzysztof
> > >
> >
>
Re: [VOTE] Release activemq-nms-openwire 1.8.0-rc1
Posted by W B D <wb...@users.sourceforge.net>.
Will there be an RC2 or a release forthcoming? I ported to .NET Core last
spring, currently using William D Cossey's fork, which is a straight port
of 1.7.x to NetStd. Looking forward to switch back to the newly refactored
official version once it's stabilized and ready to test.
On Mon, Aug 17, 2020 at 8:26 AM Havret <h4...@gmail.com> wrote:
> Thanks, Robbie. I'm canceling the vote then.
>
> On Mon, Aug 17, 2020 at 4:26 PM Robbie Gemmell <ro...@gmail.com>
> wrote:
>
> > -1 (non-binding)
> >
> > The zip has similar permission issues seen on prior NMS related
> > candidates when extracting on Linux, meaning you can extract the zip
> > but then can't simply delete the resulting content (which would again
> > be easier if contained in a subdir).
> >
> > The LICENCE file looks to include various cruft it shouldn't (in
> > particular various Java stuff sticks out, plus there are multiple
> > needless copies of the ALv2...seems like a lot of this isnt NMS
> > relevant).
> >
> > The NOTICE file needs its years updated, component name fixed, the
> > silly header removed, and perhaps the content looked at for accuracy
> > (is that referenced component actually included, not clear it is?)
> >
> > I also dont see a tag relating to the vote. There were some
> > release-related source changes made in the source repo after the
> > archives were added to dist dev area, though I think those were in the
> > archive? They'd need to be if required to recreate the release bits. A
> > tag should exist for whats in it either way.
> >
> > Robbie
> >
> > On Sun, 16 Aug 2020 at 18:36, Havret <h4...@gmail.com> wrote:
> > >
> > > Hi All,
> > >
> > > I have put together a release of activemq-nms-openwire, please
> > > check it and vote accordingly.
> > >
> > > This release brings .NET Standard 2.0 support.
> > >
> > > The files can be grabbed from:
> > >
> >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/1.8.0-rc1/
> > >
> > > Regards,
> > > Krzysztof
> >
>
Re: [VOTE] Release activemq-nms-openwire 1.8.0-rc1
Posted by Havret <h4...@gmail.com>.
Thanks, Robbie. I'm canceling the vote then.
On Mon, Aug 17, 2020 at 4:26 PM Robbie Gemmell <ro...@gmail.com>
wrote:
> -1 (non-binding)
>
> The zip has similar permission issues seen on prior NMS related
> candidates when extracting on Linux, meaning you can extract the zip
> but then can't simply delete the resulting content (which would again
> be easier if contained in a subdir).
>
> The LICENCE file looks to include various cruft it shouldn't (in
> particular various Java stuff sticks out, plus there are multiple
> needless copies of the ALv2...seems like a lot of this isnt NMS
> relevant).
>
> The NOTICE file needs its years updated, component name fixed, the
> silly header removed, and perhaps the content looked at for accuracy
> (is that referenced component actually included, not clear it is?)
>
> I also dont see a tag relating to the vote. There were some
> release-related source changes made in the source repo after the
> archives were added to dist dev area, though I think those were in the
> archive? They'd need to be if required to recreate the release bits. A
> tag should exist for whats in it either way.
>
> Robbie
>
> On Sun, 16 Aug 2020 at 18:36, Havret <h4...@gmail.com> wrote:
> >
> > Hi All,
> >
> > I have put together a release of activemq-nms-openwire, please
> > check it and vote accordingly.
> >
> > This release brings .NET Standard 2.0 support.
> >
> > The files can be grabbed from:
> >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/1.8.0-rc1/
> >
> > Regards,
> > Krzysztof
>
Re: [VOTE] Release activemq-nms-openwire 1.8.0-rc1
Posted by Robbie Gemmell <ro...@gmail.com>.
-1 (non-binding)
The zip has similar permission issues seen on prior NMS related
candidates when extracting on Linux, meaning you can extract the zip
but then can't simply delete the resulting content (which would again
be easier if contained in a subdir).
The LICENCE file looks to include various cruft it shouldn't (in
particular various Java stuff sticks out, plus there are multiple
needless copies of the ALv2...seems like a lot of this isnt NMS
relevant).
The NOTICE file needs its years updated, component name fixed, the
silly header removed, and perhaps the content looked at for accuracy
(is that referenced component actually included, not clear it is?)
I also dont see a tag relating to the vote. There were some
release-related source changes made in the source repo after the
archives were added to dist dev area, though I think those were in the
archive? They'd need to be if required to recreate the release bits. A
tag should exist for whats in it either way.
Robbie
On Sun, 16 Aug 2020 at 18:36, Havret <h4...@gmail.com> wrote:
>
> Hi All,
>
> I have put together a release of activemq-nms-openwire, please
> check it and vote accordingly.
>
> This release brings .NET Standard 2.0 support.
>
> The files can be grabbed from:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/1.8.0-rc1/
>
> Regards,
> Krzysztof