You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/26 00:54:18 UTC
[GitHub] [airflow] ferruzzi opened a new pull request #21828: Update ECS sample DAG and Docs to new standards
ferruzzi opened a new pull request #21828:
URL: https://github.com/apache/airflow/pull/21828
Part of a project to simplify and standardize AWS sample dags and docs in preparation for adding System Testing.
Related: https://github.com/apache/airflow/pull/21523
Related: https://github.com/apache/airflow/pull/21475
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21828: Update ECS sample DAG and Docs to new standards
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21828:
URL: https://github.com/apache/airflow/pull/21828#issuecomment-1054703438
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a change in pull request #21828: Update ECS sample DAG and Docs to new standards
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on a change in pull request #21828:
URL: https://github.com/apache/airflow/pull/21828#discussion_r816110365
##########
File path: airflow/providers/amazon/aws/example_dags/example_ecs_fargate.py
##########
@@ -14,61 +14,39 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-"""
-This is an example dag for EcsOperator.
-
-The task "hello_world" runs `hello-world` task in `c` cluster.
-It overrides the command in the `hello-world-container` container.
-"""
Review comment:
It's the only sample DAG in the AWS provider package that had it, and I didn't see any added value in this instance.
Discussed it a little on Slack here: https://apache-airflow.slack.com/archives/CJ1LVREHX/p1644527546510599****
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a change in pull request #21828: Update ECS sample DAG and Docs to new standards
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on a change in pull request #21828:
URL: https://github.com/apache/airflow/pull/21828#discussion_r816110365
##########
File path: airflow/providers/amazon/aws/example_dags/example_ecs_fargate.py
##########
@@ -14,61 +14,39 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-"""
-This is an example dag for EcsOperator.
-
-The task "hello_world" runs `hello-world` task in `c` cluster.
-It overrides the command in the `hello-world-container` container.
-"""
Review comment:
It's the only sample DAG in the AWS provider package that had it, and I didn't see any added value in this instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a change in pull request #21828: Update ECS sample DAG and Docs to new standards
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on a change in pull request #21828:
URL: https://github.com/apache/airflow/pull/21828#discussion_r816111235
##########
File path: airflow/providers/amazon/aws/example_dags/example_ecs_fargate.py
##########
@@ -14,61 +14,39 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-"""
-This is an example dag for EcsOperator.
-
-The task "hello_world" runs `hello-world` task in `c` cluster.
-It overrides the command in the `hello-world-container` container.
-"""
Review comment:
Discussed it a little on Slack here: https://apache-airflow.slack.com/archives/CJ1LVREHX/p1644527546510599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #21828: Update ECS sample DAG and Docs to new standards
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #21828:
URL: https://github.com/apache/airflow/pull/21828#discussion_r815395647
##########
File path: airflow/providers/amazon/aws/example_dags/example_ecs_fargate.py
##########
@@ -14,61 +14,39 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-"""
-This is an example dag for EcsOperator.
-
-The task "hello_world" runs `hello-world` task in `c` cluster.
-It overrides the command in the `hello-world-container` container.
-"""
Review comment:
Is there a reason to remove it?
Since we have `dag.doc_md = __doc__` this explanatory block will appear in the UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #21828: Update ECS sample DAG and Docs to new standards
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #21828:
URL: https://github.com/apache/airflow/pull/21828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org