You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/19 06:56:27 UTC

[GitHub] [flink] wuqingzhi128 opened a new pull request, #20305: [FLINK-28603] nextNameOffset should be capitalized and separated by an underscore.

wuqingzhi128 opened a new pull request, #20305:
URL: https://github.com/apache/flink/pull/20305

   ## What is the purpose of the change
   
   *
   Hello, I found a code style problem in flick, which is located in RpcServiceUtils, where nextNameOffset should be capitalized and separated by an underscore.
   *
   
   
   ## Brief change log
     - *rename  nextNameOffset to NEXT_NAME_OFFSET*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *AkkaRpcActorTest*.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20305: [FLINK-28603] nextNameOffset should be capitalized and separated by an underscore.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20305:
URL: https://github.com/apache/flink/pull/20305#issuecomment-1188675759

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "af3731aa8ae7166ef25c3c232ced91cbe51b6c95",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "af3731aa8ae7166ef25c3c232ced91cbe51b6c95",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * af3731aa8ae7166ef25c3c232ced91cbe51b6c95 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol closed pull request #20305: [FLINK-28603] nextNameOffset should be capitalized and separated by an underscore.

Posted by GitBox <gi...@apache.org>.
zentol closed pull request #20305: [FLINK-28603] nextNameOffset should be capitalized and separated by an underscore.
URL: https://github.com/apache/flink/pull/20305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #20305: [FLINK-28603] nextNameOffset should be capitalized and separated by an underscore.

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20305:
URL: https://github.com/apache/flink/pull/20305#issuecomment-1188706394

   Closing as per JIRA comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org