You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/19 23:30:03 UTC

[GitHub] xtinec commented on a change in pull request #6898: Address tooltip's disappearance and stickiness

xtinec commented on a change in pull request #6898: Address tooltip's disappearance and stickiness
URL: https://github.com/apache/incubator-superset/pull/6898#discussion_r258275698
 
 

 ##########
 File path: superset/assets/src/visualizations/nvd3/utils.js
 ##########
 @@ -165,11 +165,17 @@ export function generateBubbleTooltipContent({
   return s;
 }
 
-export function hideTooltips(element) {
-  if (element) {
-    const targets = element.querySelectorAll('.nvtooltip');
-    if (targets.length > 0) {
-      targets.forEach(t => t.remove());
+export function hideTooltips(shouldRemove) {
 
 Review comment:
   👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org