You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/18 17:51:06 UTC

[GitHub] [arrow] wjones127 commented on a change in pull request #12091: ARROW-14798: [C++][Python][R] Add container window to PrettyPrintOptions

wjones127 commented on a change in pull request #12091:
URL: https://github.com/apache/arrow/pull/12091#discussion_r787011301



##########
File path: cpp/src/arrow/pretty_print_test.cc
##########
@@ -715,17 +715,35 @@ TEST_F(TestPrettyPrint, ListType) {
     3
   ]
 ])expected";
+  static const char* ex_4 = R"expected([
+  [
+    null
+  ],
+  [],
+  ...
+  [
+    4,
+    6,
+    7
+  ],
+  [
+    2,
+    3
+  ]
+])expected";
 
   auto array = ArrayFromJSON(list_type, "[[null], [], null, [4, 6, 7], [2, 3]]");
-  CheckArray(*array, {0, 10}, ex);
-  CheckArray(*array, {2, 10}, ex_2);
-  CheckStream(*array, {0, 1}, ex_3);
+  CheckArray(*array, {0, 10, 5}, ex, false);

Review comment:
       Yeah I agree. Wasn't practiced anywhere else in the file, but happy to move it in the right direction :smile:.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org