You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/04/15 18:47:43 UTC

[PR] [SPARK-56492][CORE][SQL] Add `SparkStringUtils.digestToHexString` [spark]

dongjoon-hyun opened a new pull request, #55353:
URL: https://github.com/apache/spark/pull/55353

   ### What changes were proposed in this pull request?
   
   This PR replaces `org.apache.commons.codec.digest.DigestUtils` with JDK's `java.security.MessageDigest` and `java.util.HexFormat` by adding `digestToHexString` utility methods to `SparkStringUtils`. It also adds a Scalastyle rule to ban `org.apache.commons.codec.digest._` imports going forward.
   
   ### Why are the changes needed?
   
   Apache Spark can use JDK built-in APIs (`java.security.MessageDigest` + `java.util.HexFormat`) instead of the third-party `commons-codec` library for SHA digest computation. This reduces external dependency usage where standard library alternatives exist.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing tests (`HashExpressionsSuite`, `ArtifactSuite`, `ArtifactStatusesHandlerSuite`).
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-6)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56492][CORE][SQL] Support `digestToHexString/md5Hex/sha256Hex` in `JavaUtils` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #55353:
URL: https://github.com/apache/spark/pull/55353#issuecomment-4256613203

   All tests passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56492][CORE][SQL] Support `digestToHexString/md5Hex/sha256Hex` in `JavaUtils` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #55353:
URL: https://github.com/apache/spark/pull/55353#issuecomment-4256842808

   Thank you so much, @viirya ~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56492][CORE][SQL] Support `digestToHexString/md5Hex/sha256Hex` in `JavaUtils` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #55353: [SPARK-56492][CORE][SQL] Support `digestToHexString/md5Hex/sha256Hex` in `JavaUtils`
URL: https://github.com/apache/spark/pull/55353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56492][CORE][SQL] Support `digestToHexString/md5Hex/sha256Hex` in `JavaUtils` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #55353:
URL: https://github.com/apache/spark/pull/55353#issuecomment-4256696697

   Could you review this PR too, please, @viirya ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56492][CORE][SQL] Support `digestToHexString/md5Hex/sha256Hex` in `JavaUtils` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #55353:
URL: https://github.com/apache/spark/pull/55353#issuecomment-4256846692

   Merged to master for Apache Spark 4.2.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org