You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/01/07 08:52:11 UTC

[Impala-ASF-CR] IMPALA-10387: Add missing overloads of mask functions used in Ranger default masking policies

Quanlong Huang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16930 )

Change subject: IMPALA-10387: Add missing overloads of mask functions used in Ranger default masking policies
......................................................................

IMPALA-10387: Add missing overloads of mask functions used in Ranger default masking policies

The mask functions in Hive are implemented through GenericUDFs which can
accept an infinite number of function signatures. Impala currently don't
support GenericUDFs. So we provide builtin mask functions with limited
overloads.

This patch adds some missing overloads that could be used by Ranger
default masking policies, e.g. MASK_HASH, MASK_SHOW_LAST_4,
MASK_DATE_SHOW_YEAR, etc.

Tests:
 - Add test coverage on all default masking policies appliced on all
   supported types.

Change-Id: Icf3e70fd7aa9f3b6d6b508b776696e61ec1fcc2e
---
M be/src/exprs/mask-functions-ir.cc
M be/src/exprs/mask-functions.h
M common/function-registry/impala_functions.py
A testdata/workloads/functional-query/queries/QueryTest/ranger_alltypes_mask.test
A testdata/workloads/functional-query/queries/QueryTest/ranger_alltypes_mask_date_show_year.test
A testdata/workloads/functional-query/queries/QueryTest/ranger_alltypes_mask_hash.test
A testdata/workloads/functional-query/queries/QueryTest/ranger_alltypes_mask_none.test
A testdata/workloads/functional-query/queries/QueryTest/ranger_alltypes_mask_null.test
A testdata/workloads/functional-query/queries/QueryTest/ranger_alltypes_mask_show_first_4.test
A testdata/workloads/functional-query/queries/QueryTest/ranger_alltypes_mask_show_last_4.test
M tests/authorization/test_ranger.py
11 files changed, 604 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/16930/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf3e70fd7aa9f3b6d6b508b776696e61ec1fcc2e
Gerrit-Change-Number: 16930
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>