You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/03 09:45:59 UTC
[GitHub] [airflow] kaxil opened a new pull request #11253: Add missing "example" tag on example DAG
kaxil opened a new pull request #11253:
URL: https://github.com/apache/airflow/pull/11253
`example_task_group` and `example_nested_branch_dag` didn't have the example tag while all the other ones do have it
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11253: Add missing "example" tag on example DAG
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11253:
URL: https://github.com/apache/airflow/pull/11253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11253: Add missing "example" tag on example DAG
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11253:
URL: https://github.com/apache/airflow/pull/11253#issuecomment-703078037
> LGTM.
>
> The only minor change I would suggest is to use consistent quotation marks, e.g. here we can follow the double marks used earlier.
Good catch, done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11253: Add missing "example" tag on example DAG
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11253:
URL: https://github.com/apache/airflow/pull/11253#discussion_r499133765
##########
File path: airflow/example_dags/example_nested_branch_dag.py
##########
@@ -27,7 +27,12 @@
from airflow.operators.python import BranchPythonOperator
from airflow.utils.dates import days_ago
-with DAG(dag_id="example_nested_branch_dag", start_date=days_ago(2), schedule_interval="@daily") as dag:
+with DAG(
+ dag_id="example_nested_branch_dag",
+ start_date=days_ago(2),
+ schedule_interval="@daily",
+ tags=['example']
Review comment:
```suggestion
tags=["example"]
```
##########
File path: airflow/example_dags/example_task_group.py
##########
@@ -25,7 +25,7 @@
from airflow.utils.task_group import TaskGroup
# [START howto_task_group]
-with DAG(dag_id="example_task_group", start_date=days_ago(2)) as dag:
+with DAG(dag_id="example_task_group", start_date=days_ago(2), tags=['example']) as dag:
Review comment:
```suggestion
with DAG(dag_id="example_task_group", start_date=days_ago(2), tags=["example"]) as dag:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org