You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/11 05:35:29 UTC

[GitHub] [incubator-superset] ktmud opened a new issue #10838: "Add Item" button in Datasource Editor too big

ktmud opened a new issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838


   "Add Item" button in Datasource Editor seems too big and ran out of the last column in the Metrics tab.
   
   ### Expected results
   
   Button doesn't overflow.
   
   ### Actual results
   
   #### Screenshots
   
   ![image](https://user-images.githubusercontent.com/335541/92867589-a4ef5580-f3b5-11ea-90fc-65481d631fbb.png)
   
   #### How to reproduce the bug
   
   1. Go to edit any datasource in the Explore page.
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: `superset version`
   - python version: `python --version`
   - node.js version: `node -v`
   - npm version: `npm -v`
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version of superset.
   - [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC edited a comment on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC edited a comment on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-691380158






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-696382294


   resolved


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC edited a comment on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC edited a comment on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-691380158






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-690885668


   Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.83. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-691380158


   @lilykuang hey Lily, this relates to your [dataset editor improvement](https://github.com/apache/incubator-superset/pull/10444) properly? could you please take a look? 🙏


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-696382294


   resolved


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC closed issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC closed issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC closed issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC closed issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-691380158






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-690885668






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
nytai commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-691381290






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
nytai commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-691381290


   this was likely introduced in https://github.com/apache/incubator-superset/commit/a3e2e65121fadc8ca507c490eb5a3b26d8153041#diff-43b9aaf2f0ad9833ac0362f7beb20235R749 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
nytai commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-691381290






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-696382294


   resolved


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-690885668


   Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.83. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-691380158






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC closed issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC closed issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-690885668






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] JunlinC edited a comment on issue #10838: "Add Item" button in Datasource Editor too big

Posted by GitBox <gi...@apache.org>.
JunlinC edited a comment on issue #10838:
URL: https://github.com/apache/incubator-superset/issues/10838#issuecomment-691380158


   @lilykuang hey Lily, this relates to your [dataset editor improvement](https://github.com/apache/incubator-superset/pull/10444) probably? could you please take a look? 🙏


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org