You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitt10prashant <gi...@git.apache.org> on 2015/07/15 15:04:07 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8639:fixing calculation mistak...
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/595
CLOUDSTACK-8639:fixing calculation mistakes in component/test_ss_doma…
test result
=========
Test secondary storage limit of domain and its sub-domains ... === TestName: test_04_create_template_delete_account | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 175.563s
OK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitt10prashant/cloudstack ss_domain_limit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/595.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #595
----
commit 2b0261fd87eb0e8d9f770cb989adbcb586d215cc
Author: nitt10prashant <ni...@gmail.com>
Date: 2015-07-15T13:03:00Z
CLOUDSTACK-8639:fixing calculation mistakes in component/test_ss_domain_limits.py
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8639:fixing calculation mistak...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/595#issuecomment-121929346
LGTM (we could decide to make this a generic macro type of construct so we guarantee unified behavior. on the other hand this is not building a rocket...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8639:fixing calculation mistak...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/595#issuecomment-121843873
I browsed the code and found out that this "templateSize = int(int(templates[0].size) / (1024**3))" was already been used in other places. So, your changes does make sense to me and therefore you get a LGTM :+1:
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8639:fixing calculation mistak...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/595
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---