You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Eric Covener <co...@gmail.com> on 2023/03/05 01:30:15 UTC
Re: svn commit: r1907972 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy/mod_proxy_wstunnel.c
> Modified: httpd/httpd/trunk/modules/http2/mod_proxy_http2.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/mod_proxy_http2.c?rev=1907972&r1=1907971&r2=1907972&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/http2/mod_proxy_http2.c (original)
> +++ httpd/httpd/trunk/modules/http2/mod_proxy_http2.c Thu Mar 2 14:30:20 2023
> @@ -154,6 +154,10 @@ static int proxy_http2_canon(request_rec
> if (apr_table_get(r->notes, "proxy-nocanon")) {
> path = url; /* this is the raw path */
> }
> + else if (apr_table_get(r->notes, "proxy-noencode")) {
> + path = url; /* this is the encoded path already */
> + search = r->args;
> + }
> else {
> path = ap_proxy_canonenc(r->pool, url, (int)strlen(url),
> enc_path, 0, r->proxyreq);
>
I think we might need to get this changed in
https://github.com/icing/mod_h2 or risk getting it backed out by
accident in a big diff later
Re: svn commit: r1907972 - in /httpd/httpd/trunk/modules: http2/mod_proxy_http2.c proxy/mod_proxy.c proxy/mod_proxy_ajp.c proxy/mod_proxy_balancer.c proxy/mod_proxy_fcgi.c proxy/mod_proxy_http.c proxy/mod_proxy_wstunnel.c
Posted by Stefan Eissing via dev <de...@httpd.apache.org>.
> Am 05.03.2023 um 02:30 schrieb Eric Covener <co...@gmail.com>:
>
>> Modified: httpd/httpd/trunk/modules/http2/mod_proxy_http2.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/mod_proxy_http2.c?rev=1907972&r1=1907971&r2=1907972&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/http2/mod_proxy_http2.c (original)
>> +++ httpd/httpd/trunk/modules/http2/mod_proxy_http2.c Thu Mar 2 14:30:20 2023
>> @@ -154,6 +154,10 @@ static int proxy_http2_canon(request_rec
>> if (apr_table_get(r->notes, "proxy-nocanon")) {
>> path = url; /* this is the raw path */
>> }
>> + else if (apr_table_get(r->notes, "proxy-noencode")) {
>> + path = url; /* this is the encoded path already */
>> + search = r->args;
>> + }
>> else {
>> path = ap_proxy_canonenc(r->pool, url, (int)strlen(url),
>> enc_path, 0, r->proxyreq);
>>
>
> I think we might need to get this changed in
> https://github.com/icing/mod_h2 or risk getting it backed out by
> accident in a big diff later
Thanks for the heads up. Just merged the recent changes in modules/http2 to my github.
Kind Regards,
Stefan