You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/06/20 00:36:25 UTC
Review Request 35673: DRILL-3326: Query with unsupported windows
function containing "AS" blocks correct error message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35673/
-----------------------------------------------------------
Review request for drill and Aman Sinha.
Bugs: DRILL-3326
https://issues.apache.org/jira/browse/DRILL-3326
Repository: drill-git
Description
-------
DRILL-3326: When inspecting SELECT-LIST, UnsupportedOperatorsVisitor will dig into AS clause
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 544a838
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 1c8b0db
Diff: https://reviews.apache.org/r/35673/diff/
Testing
-------
Unit, others are on the way
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 35673: DRILL-3326: Query with unsupported windows
function containing "AS" blocks correct error message
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
> On June 23, 2015, 11:27 p.m., Aman Sinha wrote:
> > exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java, line 203
> > <https://reviews.apache.org/r/35673/diff/2/?file=989815#file989815line203>
> >
> > It wasn't clear why you were using non-existent columns 'age' and 'contribution' in this test that is querying the nation table. I thought DRILL-3326 is about unsupported window functions that are getting masked by the aliasing.
That was copy-paste mistake. A new patch has addressed that
- Sean Hsuan-Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35673/#review89084
-----------------------------------------------------------
On June 24, 2015, 12:12 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35673/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 12:12 a.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3326
> https://issues.apache.org/jira/browse/DRILL-3326
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-3326: When inspecting SELECT-LIST, UnsupportedOperatorsVisitor will dig into AS clause
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 544a838
> exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 1c8b0db
>
> Diff: https://reviews.apache.org/r/35673/diff/
>
>
> Testing
> -------
>
> Unit, others are on the way
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 35673: DRILL-3326: Query with unsupported windows
function containing "AS" blocks correct error message
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35673/#review89084
-----------------------------------------------------------
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java (line 203)
<https://reviews.apache.org/r/35673/#comment141684>
It wasn't clear why you were using non-existent columns 'age' and 'contribution' in this test that is querying the nation table. I thought DRILL-3326 is about unsupported window functions that are getting masked by the aliasing.
- Aman Sinha
On June 22, 2015, 5:10 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35673/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 5:10 p.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3326
> https://issues.apache.org/jira/browse/DRILL-3326
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-3326: When inspecting SELECT-LIST, UnsupportedOperatorsVisitor will dig into AS clause
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 544a838
> exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 1c8b0db
>
> Diff: https://reviews.apache.org/r/35673/diff/
>
>
> Testing
> -------
>
> Unit, others are on the way
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 35673: DRILL-3326: Query with unsupported windows
function containing "AS" blocks correct error message
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35673/#review89130
-----------------------------------------------------------
Ship it!
Ship It!
- Aman Sinha
On June 24, 2015, 12:15 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35673/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 12:15 a.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3326
> https://issues.apache.org/jira/browse/DRILL-3326
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-3326: When inspecting SELECT-LIST, UnsupportedOperatorsVisitor will dig into AS clause
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 544a838
> exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 1c8b0db
>
> Diff: https://reviews.apache.org/r/35673/diff/
>
>
> Testing
> -------
>
> Unit, others are on the way
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 35673: DRILL-3326: Query with unsupported windows
function containing "AS" blocks correct error message
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35673/
-----------------------------------------------------------
(Updated June 24, 2015, 12:15 a.m.)
Review request for drill and Aman Sinha.
Changes
-------
Addressed the comment
Bugs: DRILL-3326
https://issues.apache.org/jira/browse/DRILL-3326
Repository: drill-git
Description
-------
DRILL-3326: When inspecting SELECT-LIST, UnsupportedOperatorsVisitor will dig into AS clause
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 544a838
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 1c8b0db
Diff: https://reviews.apache.org/r/35673/diff/
Testing
-------
Unit, others are on the way
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 35673: DRILL-3326: Query with unsupported windows
function containing "AS" blocks correct error message
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35673/
-----------------------------------------------------------
(Updated June 24, 2015, 12:12 a.m.)
Review request for drill and Aman Sinha.
Changes
-------
addressed review comment
Bugs: DRILL-3326
https://issues.apache.org/jira/browse/DRILL-3326
Repository: drill-git
Description
-------
DRILL-3326: When inspecting SELECT-LIST, UnsupportedOperatorsVisitor will dig into AS clause
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 544a838
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 1c8b0db
Diff: https://reviews.apache.org/r/35673/diff/
Testing
-------
Unit, others are on the way
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 35673: DRILL-3326: Query with unsupported windows
function containing "AS" blocks correct error message
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35673/
-----------------------------------------------------------
(Updated June 22, 2015, 5:10 p.m.)
Review request for drill and Aman Sinha.
Changes
-------
revise comments
Bugs: DRILL-3326
https://issues.apache.org/jira/browse/DRILL-3326
Repository: drill-git
Description
-------
DRILL-3326: When inspecting SELECT-LIST, UnsupportedOperatorsVisitor will dig into AS clause
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 544a838
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java 1c8b0db
Diff: https://reviews.apache.org/r/35673/diff/
Testing
-------
Unit, others are on the way
Thanks,
Sean Hsuan-Yi Chu